From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbcAVMJl (ORCPT ); Fri, 22 Jan 2016 07:09:41 -0500 Received: from lists.s-osg.org ([54.187.51.154]:37712 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752733AbcAVMJf (ORCPT ); Fri, 22 Jan 2016 07:09:35 -0500 Subject: Re: [PATCH v2 10/10] ARM: multi_v7_defconfig: Remove MAX77802 RTC Kconfig symbol To: Laxman Dewangan , linux-kernel@vger.kernel.org References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-11-git-send-email-javier@osg.samsung.com> <56A1FD25.7020008@nvidia.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Arnd Bergmann , Olof Johansson , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <56A21BF8.8000901@osg.samsung.com> Date: Fri, 22 Jan 2016 09:09:28 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56A1FD25.7020008@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Laxman, On 01/22/2016 06:57 AM, Laxman Dewangan wrote: > > On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: >> The driver has been removed so the Kconfig symbol is not valid anymore. >> >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Krzysztof Kozlowski >> >> >> --- >> >> Changes in v2: >> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #10. >> >> arch/arm/configs/multi_v7_defconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig >> index 314f6be2dca2..bdb42c09332c 100644 >> --- a/arch/arm/configs/multi_v7_defconfig >> +++ b/arch/arm/configs/multi_v7_defconfig >> @@ -664,7 +664,6 @@ CONFIG_RTC_DRV_MAX8907=y >> CONFIG_RTC_DRV_MAX8997=m >> CONFIG_RTC_DRV_MAX77686=y >> CONFIG_RTC_DRV_RK808=m >> -CONFIG_RTC_DRV_MAX77802=m > > Do you need to make > > CONFIG_RTC_DRV_MAX77686=m > Yes we should, the RTC_DRV_MAX778686 Kconfig symbol was enabled in multi_v7 before the "build as much as possible as a module" policy was asked so got enabled built-in. The RTC_DRV_MAX77802 was introduced later so it was asked to be built as a module instead. I think we could do that as a separate patch though, once this series land. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org (lists.s-osg.org. [54.187.51.154]) by gmr-mx.google.com with ESMTP id ui7si642046pab.0.2016.01.22.04.09.35 for ; Fri, 22 Jan 2016 04:09:35 -0800 (PST) Subject: [rtc-linux] Re: [PATCH v2 10/10] ARM: multi_v7_defconfig: Remove MAX77802 RTC Kconfig symbol To: Laxman Dewangan , linux-kernel@vger.kernel.org References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-11-git-send-email-javier@osg.samsung.com> <56A1FD25.7020008@nvidia.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Arnd Bergmann , Olof Johansson , linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <56A21BF8.8000901@osg.samsung.com> Date: Fri, 22 Jan 2016 09:09:28 -0300 MIME-Version: 1.0 In-Reply-To: <56A1FD25.7020008@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hello Laxman, On 01/22/2016 06:57 AM, Laxman Dewangan wrote: > > On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: >> The driver has been removed so the Kconfig symbol is not valid anymore. >> >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Krzysztof Kozlowski >> >> >> --- >> >> Changes in v2: >> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #10. >> >> arch/arm/configs/multi_v7_defconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig >> index 314f6be2dca2..bdb42c09332c 100644 >> --- a/arch/arm/configs/multi_v7_defconfig >> +++ b/arch/arm/configs/multi_v7_defconfig >> @@ -664,7 +664,6 @@ CONFIG_RTC_DRV_MAX8907=y >> CONFIG_RTC_DRV_MAX8997=m >> CONFIG_RTC_DRV_MAX77686=y >> CONFIG_RTC_DRV_RK808=m >> -CONFIG_RTC_DRV_MAX77802=m > > Do you need to make > > CONFIG_RTC_DRV_MAX77686=m > Yes we should, the RTC_DRV_MAX778686 Kconfig symbol was enabled in multi_v7 before the "build as much as possible as a module" policy was asked so got enabled built-in. The RTC_DRV_MAX77802 was introduced later so it was asked to be built as a module instead. I think we could do that as a separate patch though, once this series land. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Fri, 22 Jan 2016 09:09:28 -0300 Subject: [PATCH v2 10/10] ARM: multi_v7_defconfig: Remove MAX77802 RTC Kconfig symbol In-Reply-To: <56A1FD25.7020008@nvidia.com> References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-11-git-send-email-javier@osg.samsung.com> <56A1FD25.7020008@nvidia.com> Message-ID: <56A21BF8.8000901@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Laxman, On 01/22/2016 06:57 AM, Laxman Dewangan wrote: > > On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: >> The driver has been removed so the Kconfig symbol is not valid anymore. >> >> Signed-off-by: Javier Martinez Canillas >> Reviewed-by: Krzysztof Kozlowski >> >> >> --- >> >> Changes in v2: >> - Add Krzysztof Kozlowski's Reviewed-by tag to patch #10. >> >> arch/arm/configs/multi_v7_defconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig >> index 314f6be2dca2..bdb42c09332c 100644 >> --- a/arch/arm/configs/multi_v7_defconfig >> +++ b/arch/arm/configs/multi_v7_defconfig >> @@ -664,7 +664,6 @@ CONFIG_RTC_DRV_MAX8907=y >> CONFIG_RTC_DRV_MAX8997=m >> CONFIG_RTC_DRV_MAX77686=y >> CONFIG_RTC_DRV_RK808=m >> -CONFIG_RTC_DRV_MAX77802=m > > Do you need to make > > CONFIG_RTC_DRV_MAX77686=m > Yes we should, the RTC_DRV_MAX778686 Kconfig symbol was enabled in multi_v7 before the "build as much as possible as a module" policy was asked so got enabled built-in. The RTC_DRV_MAX77802 was introduced later so it was asked to be built as a module instead. I think we could do that as a separate patch though, once this series land. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America