From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753825AbcAVNx0 (ORCPT ); Fri, 22 Jan 2016 08:53:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46272 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413AbcAVNxV (ORCPT ); Fri, 22 Jan 2016 08:53:21 -0500 Message-ID: <56A23450.8090900@redhat.com> Date: Fri, 22 Jan 2016 08:53:20 -0500 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Heiko Carstens , Andrew Morton CC: Christian Borntraeger , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/bug: make panic_on_warn available for all architectures References: <1453468336-60133-1-git-send-email-heiko.carstens@de.ibm.com> In-Reply-To: <1453468336-60133-1-git-send-email-heiko.carstens@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/22/2016 08:12 AM, Heiko Carstens wrote: > Christian Borntraeger reported that panic_on_warn doesn't have any > effect on s390. > > The panic_on_warn feature was introduced with 9e3961a09798 ("kernel: > add panic_on_warn"). However it did care only for the case when > WANT_WARN_ON_SLOWPATH is defined. This is turn is only the case for > architectures which do not have an own __WARN_TAINT defined. > > Other architectures which do have __WARN_TAINT defined call > report_bug() for warnings within lib/bug.c which does not call panic() > in case panic_on_warn is set. > > Let's simply enable the panic_on_warn feature by adding the same code > like it was added to warn_slowpath_common() in panic.c. > > This enables panic_on_warn also for arm64, parisc, powerpc, s390 and > sh. > > Cc: Prarit Bhargava > Reported-by: Christian Borntraeger > Signed-off-by: Heiko Carstens Acked-by: Prarit Bhargava P.