From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753351AbcAVTmV (ORCPT ); Fri, 22 Jan 2016 14:42:21 -0500 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:54118 "EHLO e06smtp07.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbcAVTmS (ORCPT ); Fri, 22 Jan 2016 14:42:18 -0500 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC] mm: Rework virtual memory accounting To: Linus Torvalds , Cyrill Gorcunov References: <20151228211015.GL2194@uranus> Cc: LKML , Linux MM , Quentin Casasnovas , Vegard Nossum , Andrew Morton , Willy Tarreau , Andy Lutomirski , Kees Cook , Vladimir Davydov , Konstantin Khlebnikov , Pavel Emelyanov , Peter Zijlstra From: Christian Borntraeger Message-ID: <56A28613.5070104@de.ibm.com> Date: Fri, 22 Jan 2016 20:42:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012219-0029-0000-0000-0000058F72CD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/28/2015 11:22 PM, Linus Torvalds wrote: > On Mon, Dec 28, 2015 at 1:10 PM, Cyrill Gorcunov wrote: >> Really sorry for delays. Konstantin, I slightly updated the >> changelog (to point where problem came from). Linus are you >> fine with accounting not only anonymous memory in VmData? > > The patch looks ok to me. I guess if somebody relies on old behavior > we may have to tweak it a bit, but on the whole this looks sane and > I'd be happy to merge it in the 4.5 merge window (and maybe even have > it marked for stable if it works out) > Just want to mention that this patch breaks older versions of valgrind (including the current release) https://bugs.kde.org/show_bug.cgi?id=357833 It is fixed in trunk (and even triggered some good cleanups, so the valgrind developers do NOT want it to get reverted). Rawhide already has the valgrind fix, others might not, so if we consider this for stable, things might break here and there, but in general this looks like a good cleanup. Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by kanga.kvack.org (Postfix) with ESMTP id 794A86B0005 for ; Fri, 22 Jan 2016 14:42:17 -0500 (EST) Received: by mail-wm0-f54.google.com with SMTP id r129so226205169wmr.0 for ; Fri, 22 Jan 2016 11:42:17 -0800 (PST) Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com. [195.75.94.111]) by mx.google.com with ESMTPS id w2si10067052wjf.153.2016.01.22.11.42.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 22 Jan 2016 11:42:16 -0800 (PST) Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Jan 2016 19:42:15 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id AAB5017D8059 for ; Fri, 22 Jan 2016 19:42:19 +0000 (GMT) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0MJgDaB6029658 for ; Fri, 22 Jan 2016 19:42:13 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0MJgC4L028086 for ; Fri, 22 Jan 2016 12:42:12 -0700 Subject: Re: [PATCH RFC] mm: Rework virtual memory accounting References: <20151228211015.GL2194@uranus> From: Christian Borntraeger Message-ID: <56A28613.5070104@de.ibm.com> Date: Fri, 22 Jan 2016 20:42:11 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds , Cyrill Gorcunov Cc: LKML , Linux MM , Quentin Casasnovas , Vegard Nossum , Andrew Morton , Willy Tarreau , Andy Lutomirski , Kees Cook , Vladimir Davydov , Konstantin Khlebnikov , Pavel Emelyanov , Peter Zijlstra On 12/28/2015 11:22 PM, Linus Torvalds wrote: > On Mon, Dec 28, 2015 at 1:10 PM, Cyrill Gorcunov wrote: >> Really sorry for delays. Konstantin, I slightly updated the >> changelog (to point where problem came from). Linus are you >> fine with accounting not only anonymous memory in VmData? > > The patch looks ok to me. I guess if somebody relies on old behavior > we may have to tweak it a bit, but on the whole this looks sane and > I'd be happy to merge it in the 4.5 merge window (and maybe even have > it marked for stable if it works out) > Just want to mention that this patch breaks older versions of valgrind (including the current release) https://bugs.kde.org/show_bug.cgi?id=357833 It is fixed in trunk (and even triggered some good cleanups, so the valgrind developers do NOT want it to get reverted). Rawhide already has the valgrind fix, others might not, so if we consider this for stable, things might break here and there, but in general this looks like a good cleanup. Christian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org