From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755439AbcAVX1g (ORCPT ); Fri, 22 Jan 2016 18:27:36 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:20607 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752942AbcAVX1d (ORCPT ); Fri, 22 Jan 2016 18:27:33 -0500 Subject: Re: [PATCH v1 02/12] xen/hvmlite: Factor out common kernel init code To: "Luis R. Rodriguez" References: <1453498558-6028-1-git-send-email-boris.ostrovsky@oracle.com> <1453498558-6028-3-git-send-email-boris.ostrovsky@oracle.com> <20160122230144.GZ20964@wotan.suse.de> <56A2B76F.4060704@oracle.com> Cc: david.vrabel@citrix.com, konrad.wilk@oracle.com, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, roger.pau@citrix.com From: Boris Ostrovsky Message-ID: <56A2BAE3.50008@oracle.com> Date: Fri, 22 Jan 2016 18:27:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <56A2B76F.4060704@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/22/2016 06:12 PM, Boris Ostrovsky wrote: > On 01/22/2016 06:01 PM, Luis R. Rodriguez wrote: >> On Fri, Jan 22, 2016 at 04:35:48PM -0500, Boris Ostrovsky wrote: >>> HVMlite guests (to be introduced in subsequent patches) share most >>> of the kernel initialization code with PV(H). >>> >>> Signed-off-by: Boris Ostrovsky >>> --- >>> arch/x86/xen/enlighten.c | 225 >>> ++++++++++++++++++++++++---------------------- >>> 1 files changed, 119 insertions(+), 106 deletions(-) >>> >>> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c >>> index d09e4c9..2cf446a 100644 >>> --- a/arch/x86/xen/enlighten.c >>> +++ b/arch/x86/xen/enlighten.c >> Whoa, I'm lost, its hard for me to tell what exactly stayed and what >> got pulled into a helper, etc. Is there a possibility to split this >> patch in 2 somehow to make the actual functional changes easier to >> read? There are too many changes here and I just can't tell easily >> what's going on. > > > The only real changes that this patch introduces is it reorders some > of the operations that used to be in xen_start_kernel(). This is done > so that in the next patch when we add hvmlite we can easily put those > specific to PV(H) inside 'if (!xen_hvm_domain())'. I probably should > have said so in the commit message. Actually, I forgot that I merged the 'if' clause into this patch already so I'll see if I can separate them again to make it easier on the eye. -boris > > It is indeed difficult to review but I don't see how I can split this. > Even if I just moved it (without reordering) it would still be hard to > read. > > -boris