From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 199CE897D7 for ; Tue, 4 Jun 2019 08:02:50 +0000 (UTC) From: "Peres, Martin" Date: Tue, 4 Jun 2019 08:02:45 +0000 Message-ID: <56A4AB1F0E1B5D4C83D27F43C50F662E58FAA0D9@IRSMSX107.ger.corp.intel.com> References: <20190531112200.22403-1-simon.ser@intel.com> <20190531112200.22403-3-simon.ser@intel.com> <77e2174039370820e4953ae7a509f6140629618d.camel@intel.com> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/5] lib/igt_eld: consolidate ELD parsing List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Ser, Simon" , "igt-dev@lists.freedesktop.org" , "martin.peres@linux.intel.com" List-ID: T24gMDMvMDYvMjAxOSAxNzozNCwgU2VyLCBTaW1vbiB3cm90ZToKPiBPbiBNb24sIDIwMTktMDYt MDMgYXQgMTU6NDIgKzAzMDAsIE1hcnRpbiBQZXJlcyB3cm90ZToKPj4gT24gMzEvMDUvMjAxOSAx NDoyMSwgU2ltb24gU2VyIHdyb3RlOgo+Pj4gTWFrZSB0aGUgRUxEIGVudW1lcmF0aW9uIG1vcmUg cm9idXN0LCBhbmQgaW1wbGVtZW50IHByb3BlciBwYXJzaW5nIGZvciBFTEQKPj4+IGZpZWxkcy4g VGhpcyB3aWxsIGJlY29tZSB1c2VmdWwgd2hlbiBvdGhlciBFTEQgZmllbGRzIChmb3JtYXRzLCBz YW1wbGUgcmF0ZXMsCj4+PiBzYW1wbGUgc2l6ZXMpIHdpbGwgYmUgcGFyc2VkIGFuZCBjaGVja2Vk Lgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFNpbW9uIFNlciA8c2ltb24uc2VyQGludGVsLmNvbT4K Pj4+IC0tLQo+Pj4gIGxpYi9pZ3RfZWxkLmMgfCA5NCArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4+ICBsaWIvaWd0X2VsZC5oIHwgIDUgKysrCj4+ PiAgMiBmaWxlcyBjaGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMoLSkKPj4+ Cj4+PiBkaWZmIC0tZ2l0IGEvbGliL2lndF9lbGQuYyBiL2xpYi9pZ3RfZWxkLmMKPj4+IGluZGV4 IDhlMGRjYzMwNmU4NS4uYTE5ODAwMWE1NmQ3IDEwMDY0NAo+Pj4gLS0tIGEvbGliL2lndF9lbGQu Ywo+Pj4gKysrIGIvbGliL2lndF9lbGQuYwo+Pj4gQEAgLTMwLDggKzMwLDEyIEBACj4+PiAgI2lu Y2x1ZGUgPHN0ZGlvLmg+Cj4+PiAgI2luY2x1ZGUgPHN0cmluZy5oPgo+Pj4gIAo+Pj4gKyNpbmNs dWRlICJpZ3RfY29yZS5oIgo+Pj4gICNpbmNsdWRlICJpZ3RfZWxkLmgiCj4+PiAgCj4+PiArI2Rl ZmluZSBFTERfUFJFRklYICJlbGQjIgo+Pj4gKyNkZWZpbmUgRUxEX0RFTElNICIgXHQiCj4+PiAr Cj4+PiAgLyoqCj4+PiAgICogRURJRC1MaWtlIERhdGEgKEVMRCkgaXMgbWV0YWRhdGEgcGFyc2Vk IGFuZCBleHBvc2VkIGJ5IEFMU0EgZm9yIEhETUkgYW5kCj4+PiAgICogRGlzcGxheVBvcnQgY29u bmVjdG9ycyBzdXBwb3J0aW5nIGF1ZGlvLiBUaGlzIGluY2x1ZGVzIHRoZSBtb25pdG9yIG5hbWUg YW5kCj4+PiBAQCAtMzksMzkgKzQzLDQ5IEBACj4+PiAgICogb24pLgo+Pj4gICAqLwo+Pj4gIAo+ Pj4gLS8qKiBlbGRfZW50cnlfaXNfaWd0OiBjaGVja3Mgd2hldGhlciBhbiBFTEQgZW50cnkgaXMg bWFwcGVkIHRvIHRoZSBJR1QgRURJRCAqLwo+Pgo+PiBQb3N0aW5nIGFuIGV4YW1wbGUgb2YgZWxk IGhlcmUgd291bGQgYmUgaGVscGZ1bDoKPj4KPj4gJCBjYXQgL3Byb2MvYXNvdW5kL2NhcmQwL2Vs ZCMwLjIKPj4gbW9uaXRvcl9wcmVzZW50ICAgICAgICAgMQo+PiBlbGRfdmFsaWQgICAgICAgICAg ICAgICAxCj4+IG1vbml0b3JfbmFtZSAgICAgICAgICAgIFUyODc5RzYKPj4KPj4gY29ubmVjdGlv bl90eXBlICAgICAgICAgRGlzcGxheVBvcnQKPj4gZWxkX3ZlcnNpb24gICAgICAgICAgICAgWzB4 Ml0gQ0VBLTg2MUQgb3IgYmVsb3cKPj4gZWRpZF92ZXJzaW9uICAgICAgICAgICAgWzB4M10gQ0VB LTg2MS1CLCBDIG9yIEQKPj4gbWFudWZhY3R1cmVfaWQgICAgICAgICAgMHhlMzA1Cj4+IHByb2R1 Y3RfaWQgICAgICAgICAgICAgIDB4Mjg3OQo+PiBwb3J0X2lkICAgICAgICAgICAgICAgICAweDgw MAo+PiBzdXBwb3J0X2hkY3AgICAgICAgICAgICAwCj4+IHN1cHBvcnRfYWkgICAgICAgICAgICAg IDAKPj4gYXVkaW9fc3luY19kZWxheSAgICAgICAgMAo+PiBzcGVha2VycyAgICAgICAgICAgICAg ICBbMHgxXSBGTC9GUgo+PiBzYWRfY291bnQgICAgICAgICAgICAgICAxCj4+IHNhZDBfY29kaW5n X3R5cGUgICAgICAgIFsweDFdIExQQ00KPj4gc2FkMF9jaGFubmVscyAgICAgICAgICAgMgo+PiBz YWQwX3JhdGVzICAgICAgICAgICAgICBbMHhlMF0gMzIwMDAgNDQxMDAgNDgwMDAKPj4gc2FkMF9i aXRzICAgICAgICAgICAgICAgWzB4ZTAwMDBdIDE2IDIwIDI0Cj4+Cj4+PiAtc3RhdGljIGJvb2wg ZWxkX2VudHJ5X2lzX2lndChjb25zdCBjaGFyICpwYXRoKQo+Pj4gK3N0YXRpYyBib29sIGVsZF9w YXJzZV9lbnRyeShjb25zdCBjaGFyICpwYXRoLCBzdHJ1Y3QgZWxkX2VudHJ5ICplbGQpCj4+PiAg ewo+Pj4gLQlGSUxFICppbjsKPj4+ICsJRklMRSAqZjsKPj4+ICAJY2hhciBidWZbMTAyNF07Cj4+ PiAtCXVpbnQ4X3QgZWxkX3ZhbGlkID0gMDsKPj4+IC0JdWludDhfdCBtb25fdmFsaWQgPSAwOwo+ Pj4gLQo+Pj4gLQlpbiA9IGZvcGVuKHBhdGgsICJyIik7Cj4+PiAtCWlmICghaW4pCj4+PiAtCQly ZXR1cm4gZmFsc2U7Cj4+PiArCWNoYXIgKmtleSwgKnZhbHVlOwo+Pj4gKwlzaXplX3QgbGVuOwo+ Pj4gKwlib29sIG1vbml0b3JfcHJlc2VudDsKPj4+ICAKPj4+IC0JbWVtc2V0KGJ1ZiwgMCwgMTAy NCk7Cj4+PiArCW1lbXNldChlbGQsIDAsIHNpemVvZigqZWxkKSk7Cj4+PiAgCj4+PiAtCXdoaWxl ICgoZmdldHMoYnVmLCAxMDI0LCBpbikpICE9IE5VTEwpIHsKPj4+IC0JCWNoYXIgKmxpbmUgPSBi dWY7Cj4+PiArCWYgPSBmb3BlbihwYXRoLCAiciIpOwo+Pj4gKwlpZiAoIWYpIHsKPj4+ICsJCWln dF9kZWJ1ZygiRmFpbGVkIHRvIG9wZW4gRUxEIGZpbGU6ICVzXG4iLCBwYXRoKTsKPj4+ICsJCXJl dHVybiBmYWxzZTsKPj4+ICsJfQo+Pj4gIAo+Pj4gLQkJaWYgKCFzdHJuY2FzZWNtcChsaW5lLCAi ZWxkX3ZhbGlkIiwgOSkgJiYKPj4+IC0JCQkJc3Ryc3RyKGxpbmUsICIxIikpIHsKPj4+IC0JCQll bGRfdmFsaWQrKzsKPj4+IC0JCX0KPj4KPj4gR29vZCByaWRkYW5jZSEgSWdub3JlIG15IGNvbW1l bnQgZnJvbSBwYXRjaCAxIQo+Pgo+Pj4gKwl3aGlsZSAoKGZnZXRzKGJ1Ziwgc2l6ZW9mKGJ1Ziks IGYpKSAhPSBOVUxMKSB7Cj4+PiArCQlsZW4gPSBzdHJsZW4oYnVmKTsKPj4+ICsJCWlmIChidWZb bGVuIC0gMV0gPT0gJ1xuJykKPj4+ICsJCQlidWZbbGVuIC0gMV0gPSAnXDAnOwo+Pj4gKwo+Pj4g KwkJa2V5ID0gc3RydG9rKGJ1ZiwgRUxEX0RFTElNKTsKPj4+ICsJCXZhbHVlID0gc3RydG9rKE5V TEwsICIiKTsKPj4KPj4gSG1tLCBJIGhhZCBmb3Jnb3R0ZW4gdGhhdCBzdHJvayB3YXMgc3RhdGVm dWwgd2hlbiBzdHIgPT0gTlVMTCEKPj4KPj4+ICsJCS8qIFNraXAgd2hpdGVzcGFjZSBhdCB0aGUg YmVnaW5uaW5nICovCj4+PiArCQl2YWx1ZSArPSBzdHJzcG4odmFsdWUsIEVMRF9ERUxJTSk7Cj4+ Cj4+IFRoYW5rcyBmb3IgdGVhY2hpbmcgbWUgYSBuZXcgZnVuY3Rpb24gOikgVGhpcyBpcyBxdWl0 ZSBwcmFjdGljYWwhCj4+Cj4+IEFmdGVyIGRvaW5nIG1vcmUgcHl0aG9uIHdvcmssIGdvaW5nIGJh Y2sgdG8gcGFyc2luZyB3aXRoIEMgaXMgYSBsaXR0bGUKPj4gcm91Z2ggOkQgTm90IGFzIGJhZCBh cyBBU00gdGhvdWdoIQo+IAo+IEVoZWgsIEkgY2FuIGltYWdpbmUgdGhhdCA6UAo+IAo+Pj4gKwo+ Pj4gKwkJaWYgKHN0cmNtcChrZXksICJtb25pdG9yX3ByZXNlbnQiKSA9PSAwKQo+Pj4gKwkJCW1v bml0b3JfcHJlc2VudCA9IHN0cmNtcCh2YWx1ZSwgIjEiKSA9PSAwOwo+Pj4gKwkJZWxzZSBpZiAo c3RyY21wKGtleSwgImVsZF92YWxpZCIpID09IDApCj4+PiArCQkJZWxkLT52YWxpZCA9IHN0cmNt cCh2YWx1ZSwgIjEiKSA9PSAwOwo+Pj4gKwkJZWxzZSBpZiAoc3RyY21wKGtleSwgIm1vbml0b3Jf bmFtZSIpID09IDApCj4+PiArCQkJc25wcmludGYoZWxkLT5tb25pdG9yX25hbWUsIHNpemVvZihl bGQtPm1vbml0b3JfbmFtZSksCj4+PiArCQkJCSAiJXMiLCB2YWx1ZSk7Cj4+PiArCX0KPj4+ICAK Pj4+IC0JCWlmICghc3RybmNhc2VjbXAobGluZSwgIm1vbml0b3JfbmFtZSIsIDEyKSAmJgo+Pj4g LQkJCQlzdHJzdHIobGluZSwgIklHVCIpKSB7Cj4+PiAtCQkJbW9uX3ZhbGlkKys7Cj4+PiAtCQl9 Cj4+PiArCWlmIChmZXJyb3IoZikgIT0gMCkgewo+Pj4gKwkJaWd0X2RlYnVnKCJGYWlsZWQgdG8g cmVhZCBFTEQgZmlsZTogJWRcbiIsIGZlcnJvcihmKSk7Cj4+PiArCQlyZXR1cm4gZmFsc2U7Cj4+ PiAgCX0KPj4+ICAKPj4+IC0JZmNsb3NlKGluKTsKPj4+IC0JaWYgKG1vbl92YWxpZCAmJiBlbGRf dmFsaWQpCj4+PiAtCQlyZXR1cm4gdHJ1ZTsKPj4+ICsJZmNsb3NlKGYpOwo+Pj4gIAo+Pj4gLQly ZXR1cm4gZmFsc2U7Cj4+PiArCXJldHVybiBtb25pdG9yX3ByZXNlbnQ7Cj4+PiAgfQo+Pj4gIAo+ Pj4gIC8qKiBlbGRfaGFzX2lndDogY2hlY2sgd2hldGhlciBBTFNBIGhhcyBkZXRlY3RlZCB0aGUg YXVkaW8tY2FwYWJsZSBJR1QgRURJRCBieQo+Pj4gQEAgLTc5LDI3ICs5MywzNSBAQCBzdGF0aWMg Ym9vbCBlbGRfZW50cnlfaXNfaWd0KGNvbnN0IGNoYXIgKnBhdGgpCj4+PiAgYm9vbCBlbGRfaGFz X2lndCh2b2lkKQo+Pj4gIHsKPj4+ICAJRElSICpkaXI7Cj4+PiAtCXN0cnVjdCBkaXJlbnQgKnNu ZF9oZGE7Cj4+PiArCXN0cnVjdCBkaXJlbnQgKmRpcmVudDsKPj4+ICAJaW50IGk7Cj4+PiArCWNo YXIgY2FyZFs2NF07Cj4+PiArCWNoYXIgcGF0aFtQQVRIX01BWF07Cj4+PiArCXN0cnVjdCBlbGRf ZW50cnkgZWxkOwo+Pj4gIAo+Pj4gIAlmb3IgKGkgPSAwOyBpIDwgODsgaSsrKSB7Cj4+PiAtCQlj aGFyIGNhcmRzWzEyOF07Cj4+PiAtCj4+PiAtCQlzbnByaW50ZihjYXJkcywgc2l6ZW9mKGNhcmRz KSwgIi9wcm9jL2Fzb3VuZC9jYXJkJWQiLCBpKTsKPj4+IC0JCWRpciA9IG9wZW5kaXIoY2FyZHMp Owo+Pj4gKwkJc25wcmludGYoY2FyZCwgc2l6ZW9mKGNhcmQpLCAiL3Byb2MvYXNvdW5kL2NhcmQl ZCIsIGkpOwo+Pj4gKwkJZGlyID0gb3BlbmRpcihjYXJkKTsKPj4+ICAJCWlmICghZGlyKQo+Pj4g IAkJCWNvbnRpbnVlOwo+Pj4gIAo+Pj4gLQkJd2hpbGUgKChzbmRfaGRhID0gcmVhZGRpcihkaXIp KSkgewo+Pj4gLQkJCWNoYXIgZnBhdGhbUEFUSF9NQVhdOwo+Pj4gKwkJd2hpbGUgKChkaXJlbnQg PSByZWFkZGlyKGRpcikpKSB7Cj4+PiArCQkJaWYgKHN0cm5jbXAoZGlyZW50LT5kX25hbWUsIEVM RF9QUkVGSVgsCj4+PiArCQkJCSAgICBzdHJsZW4oRUxEX1BSRUZJWCkpICE9IDApCj4+PiArCQkJ CWNvbnRpbnVlOwo+Pj4gKwo+Pj4gKwkJCXNucHJpbnRmKHBhdGgsIHNpemVvZihwYXRoKSwgIiVz LyVzIiwgY2FyZCwKPj4+ICsJCQkJIGRpcmVudC0+ZF9uYW1lKTsKPj4+ICsJCQlpZiAoIWVsZF9w YXJzZV9lbnRyeShwYXRoLCAmZWxkKSkgewo+Pj4gKwkJCQljb250aW51ZTsKPj4+ICsJCQl9Cj4+ PiAgCj4+PiAtCQkJaWYgKCpzbmRfaGRhLT5kX25hbWUgPT0gJy4nIHx8Cj4+PiAtCQkJICAgIHN0 cnN0cihzbmRfaGRhLT5kX25hbWUsICJlbGQiKSA9PSAwKQo+Pj4gKwkJCWlmICghZWxkLnZhbGlk KSB7Cj4+PiArCQkJCWlndF9kZWJ1ZygiU2tpcHBpbmcgaW52YWxpZCBFTEQ6ICVzXG4iLCBwYXRo KTsKPj4KPj4gVGhlIG1lc3NhZ2UgaXMgYSBsaXR0bGUgY29uZnVzaW5nLiBIb3cgYWJvdXQgIlNr aXBwaW5nIG5vbi1FTEQgZmlsZToKPj4gJXNcbiIgaW5zdGVhZD8KPiAKPiBTbywgdGhpcyBpcyBu b3QgZXhhY3RseSBhIG5vbi1FTEQgZmlsZTogdGhpcyBoYXBwZW5zIHdoZW4gdGhlIEVESUQKPiBp c24ndCB2YWxpZCAoZS5nLiBpZiBzb21lIGZpZWxkIGlzIG1hbGZvcm1lZCkuCgpSaWdodCwgdGhh dCB3YXMgdGhlIHByZXZpb3VzIGNvZGUgdGhhdCB3YXMgY2hlY2tpbmcgdGhhdCwgYnV0IHlvdSBt b3ZlZAppdCB0byB0aGUgdG9wIHdpdGggdGhlIHN0cmNtcC4KCj4gCj4gSXMgaXQgb2theSBpZiBJ IGNoYW5nZSBpdCB0bzogIlNraXBwaW5nIEVMRCBlbnRyeSB3aXRoIGludmFsaWQ9MSI/CgpJIHRo aW5rIHlvdXIgb3JpZ2luYWwgbWVzc2FnZSB3YXMgYmV0dGVyLiBTb3JyeSBmb3IgdGhlIG5vaXNl ISBGZWVsIGZyZWUKdG8gbWVyZ2UhCgo+IAo+PiBBbnl3YXksIEkgbGlrZSB3aGVyZSB0aGlzIGlz IGdvaW5nIQo+Pgo+PiBSZXZpZXdlZC1ieTogTWFydGluIFBlcmVzIDxtYXJ0aW4ucGVyZXNAbGlu dXguaW50ZWwuY29tPgo+Pgo+Pj4gIAkJCQljb250aW51ZTsKPj4+ICsJCQl9Cj4+PiAgCj4+PiAt CQkJc25wcmludGYoZnBhdGgsIHNpemVvZihmcGF0aCksICIlcy8lcyIsIGNhcmRzLAo+Pj4gLQkJ CQkgc25kX2hkYS0+ZF9uYW1lKTsKPj4+IC0JCQlpZiAoZWxkX2VudHJ5X2lzX2lndChmcGF0aCkp IHsKPj4+ICsJCQlpZiAoc3RyY21wKGVsZC5tb25pdG9yX25hbWUsICJJR1QiKSA9PSAwKSB7Cj4+ PiAgCQkJCWNsb3NlZGlyKGRpcik7Cj4+PiAgCQkJCXJldHVybiB0cnVlOwo+Pj4gIAkJCX0KPj4+ IGRpZmYgLS1naXQgYS9saWIvaWd0X2VsZC5oIGIvbGliL2lndF9lbGQuaAo+Pj4gaW5kZXggMjdm ODc2ZDlmNjMxLi4yMWZlMzUzN2FjZjkgMTAwNjQ0Cj4+PiAtLS0gYS9saWIvaWd0X2VsZC5oCj4+ PiArKysgYi9saWIvaWd0X2VsZC5oCj4+PiBAQCAtMzAsNiArMzAsMTEgQEAKPj4+ICAKPj4+ICAj aW5jbHVkZSA8c3RkYm9vbC5oPgo+Pj4gIAo+Pj4gK3N0cnVjdCBlbGRfZW50cnkgewo+Pj4gKwli b29sIHZhbGlkOwo+Pj4gKwljaGFyIG1vbml0b3JfbmFtZVsxNl07Cj4+PiArfTsKPj4+ICsKPj4+ ICBib29sIGVsZF9oYXNfaWd0KHZvaWQpOwo+Pj4gIAo+Pj4gICNlbmRpZgo+Pj4KPiAKCi0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQpJbnRlbCBGaW5sYW5kIE95ClJlZ2lzdGVyZWQgQWRkcmVzczogUEwgMjgxLCAwMDE4 MSBIZWxzaW5raSAKQnVzaW5lc3MgSWRlbnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCkRvbWljaWxl ZCBpbiBIZWxzaW5raSAKClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRh aW4gY29uZmlkZW50aWFsIG1hdGVyaWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVk IHJlY2lwaWVudChzKS4gQW55IHJldmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0 cmljdGx5IHByb2hpYml0ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQs IHBsZWFzZSBjb250YWN0IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5n IGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2