From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755288AbcAYEP7 (ORCPT ); Sun, 24 Jan 2016 23:15:59 -0500 Received: from darkcity.gna.ch ([195.226.6.51]:48144 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755236AbcAYEP5 (ORCPT ); Sun, 24 Jan 2016 23:15:57 -0500 Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= References: <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> <20160122151835.GM23290@intel.com> Cc: LKML , dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Vlastimil Babka From: =?UTF-8?Q?Michel_D=c3=a4nzer?= X-Enigmail-Draft-Status: N1110 Message-ID: <56A5A171.7000205@daenzer.net> Date: Mon, 25 Jan 2016 13:15:45 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160122151835.GM23290@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.01.2016 00:18, Ville Syrjälä wrote: > On Fri, Jan 22, 2016 at 12:06:00PM +0900, Michel Dänzer wrote: >> >> [ Trimming KDE folks from Cc ] >> >> On 21.01.2016 19:09, Daniel Vetter wrote: >>> On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: >>>> On 21.01.2016 16:58, Daniel Vetter wrote: >>>>> >>>>> Can you please point me at the vblank on/off jump bug please? >>>> >>>> AFAIR I originally reported it in response to >>>> http://lists.freedesktop.org/archives/dri-devel/2015-August/087841.html >>>> , but I can't find that in the archives, so maybe that was just on IRC. >>>> See >>>> http://lists.freedesktop.org/archives/dri-devel/2016-January/099122.html >>>> . Basically, I ran into the bug fixed by your patch because the counter >>>> jumped forward on every DPMS off, so it hit the 32-bit boundary after >>>> just a few days. >>> >>> Ok, so just uncovered the overflow bug. >> >> Not sure what you mean by "just", but to be clear: The drm_vblank_on/off >> counter jumping bug (similar to the bug this thread is about), which >> exposed the overflow bug, is still alive and kicking in 4.5. It seems >> to happen when turning off the CRTC: >> >> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=0, hw=916 hw_last=916 >> [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 >> [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x7 p(2199,-45)@ 7304.307354 -> 7304.308006 [e 0 us, 0 rep] >> [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=16776301, hw=1 hw_last=916 > > Not sure what bug we're talking about here, but here the hw counter > clearly jumps backwards. > >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 1: current=0, diff=0, hw=0 hw_last=0 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 2: current=0, diff=0, hw=0 hw_last=0 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 3: current=0, diff=0, hw=0 hw_last=0 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 >> [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x1 p(0,0)@ 7304.317140 -> 7304.317140 [e 0 us, 0 rep] >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 >> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=234880995, diff=16777215, hw=0 hw_last=1 > > Same here. At least one of the jumps is expected, because this is around turning off the CRTC for DPMS off. Don't know yet why there are two jumps back though. > These things just don't happen on i915 because drm_vblank_off() and > drm_vblank_on() are always called around the times when the hw counter > might get reset. Or at least that's how it should be. Which is of course the idea of Daniel's patch (which is what I'm getting the above with) or Mario's patch as well, but clearly something's still wrong. It's certainly possible that it's something in the driver, but since calling drm_vblank_pre/post_modeset from the same places seems to work fine (ignoring the regression discussed in this thread)... Do drm_vblank_on/off require something else to handle this correctly? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Date: Mon, 25 Jan 2016 13:15:45 +0900 Message-ID: <56A5A171.7000205@daenzer.net> References: <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> <20160122151835.GM23290@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 5007F6E44F for ; Sun, 24 Jan 2016 20:15:57 -0800 (PST) In-Reply-To: <20160122151835.GM23290@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Alex Deucher , Vlastimil Babka , LKML , dri-devel@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: dri-devel@lists.freedesktop.org T24gMjMuMDEuMjAxNiAwMDoxOCwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+IE9uIEZyaSwgSmFu IDIyLCAyMDE2IGF0IDEyOjA2OjAwUE0gKzA5MDAsIE1pY2hlbCBEw6RuemVyIHdyb3RlOgo+Pgo+ PiBbIFRyaW1taW5nIEtERSBmb2xrcyBmcm9tIENjIF0KPj4KPj4gT24gMjEuMDEuMjAxNiAxOTow OSwgRGFuaWVsIFZldHRlciB3cm90ZToKPj4+IE9uIFRodSwgSmFuIDIxLCAyMDE2IGF0IDA1OjM2 OjQ2UE0gKzA5MDAsIE1pY2hlbCBEw6RuemVyIHdyb3RlOgo+Pj4+IE9uIDIxLjAxLjIwMTYgMTY6 NTgsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+Pj4+Cj4+Pj4+IENhbiB5b3UgcGxlYXNlIHBvaW50 IG1lIGF0IHRoZSB2Ymxhbmsgb24vb2ZmIGp1bXAgYnVnIHBsZWFzZT8KPj4+Pgo+Pj4+IEFGQUlS IEkgb3JpZ2luYWxseSByZXBvcnRlZCBpdCBpbiByZXNwb25zZSB0bwo+Pj4+IGh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTUtQXVndXN0LzA4Nzg0MS5o dG1sCj4+Pj4gLCBidXQgSSBjYW4ndCBmaW5kIHRoYXQgaW4gdGhlIGFyY2hpdmVzLCBzbyBtYXli ZSB0aGF0IHdhcyBqdXN0IG9uIElSQy4KPj4+PiBTZWUKPj4+PiBodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE2LUphbnVhcnkvMDk5MTIyLmh0bWwKPj4+ PiAuIEJhc2ljYWxseSwgSSByYW4gaW50byB0aGUgYnVnIGZpeGVkIGJ5IHlvdXIgcGF0Y2ggYmVj YXVzZSB0aGUgY291bnRlcgo+Pj4+IGp1bXBlZCBmb3J3YXJkIG9uIGV2ZXJ5IERQTVMgb2ZmLCBz byBpdCBoaXQgdGhlIDMyLWJpdCBib3VuZGFyeSBhZnRlcgo+Pj4+IGp1c3QgYSBmZXcgZGF5cy4K Pj4+Cj4+PiBPaywgc28ganVzdCB1bmNvdmVyZWQgdGhlIG92ZXJmbG93IGJ1Zy4KPj4KPj4gTm90 IHN1cmUgd2hhdCB5b3UgbWVhbiBieSAianVzdCIsIGJ1dCB0byBiZSBjbGVhcjogVGhlIGRybV92 Ymxhbmtfb24vb2ZmCj4+IGNvdW50ZXIganVtcGluZyBidWcgKHNpbWlsYXIgdG8gdGhlIGJ1ZyB0 aGlzIHRocmVhZCBpcyBhYm91dCksIHdoaWNoCj4+IGV4cG9zZWQgdGhlIG92ZXJmbG93IGJ1Zywg aXMgc3RpbGwgYWxpdmUgYW5kIGtpY2tpbmcgaW4gNC41LiBJdCBzZWVtcwo+PiB0byBoYXBwZW4g d2hlbiB0dXJuaW5nIG9mZiB0aGUgQ1JUQzoKPj4KPj4gW2RybTpkcm1fdXBkYXRlX3ZibGFua19j b3VudF0gdXBkYXRpbmcgdmJsYW5rIGNvdW50IG9uIGNydGMgMDogY3VycmVudD0yMTgxMDQ2OTQs IGRpZmY9MCwgaHc9OTE2IGh3X2xhc3Q9OTE2Cj4+IFtkcm06cmFkZW9uX2dldF92YmxhbmtfY291 bnRlcl9rbXNdIGNydGMgMDogZGlzdCBmcm9tIHZibGFuayBzdGFydCAzCj4+IFtkcm06ZHJtX2Nh bGNfdmJsdGltZXN0YW1wX2Zyb21fc2Nhbm91dHBvc10gY3J0YyAwIDogdiAweDcgcCgyMTk5LC00 NSlAIDczMDQuMzA3MzU0IC0+IDczMDQuMzA4MDA2IFtlIDAgdXMsIDAgcmVwXQo+PiBbZHJtOnJh ZGVvbl9nZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBjcnRjIDA6IGRpc3QgZnJvbSB2Ymxhbmsgc3Rh cnQgMwo+PiBbZHJtOmRybV91cGRhdGVfdmJsYW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291 bnQgb24gY3J0YyAwOiBjdXJyZW50PTIxODEwNDY5NCwgZGlmZj0xNjc3NjMwMSwgaHc9MSBod19s YXN0PTkxNgo+IAo+IE5vdCBzdXJlIHdoYXQgYnVnIHdlJ3JlIHRhbGtpbmcgYWJvdXQgaGVyZSwg YnV0IGhlcmUgdGhlIGh3IGNvdW50ZXIKPiBjbGVhcmx5IGp1bXBzIGJhY2t3YXJkcy4KPiAKPj4g W2RybTpyYWRlb25fZ2V0X3ZibGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0IDMK Pj4gW2RybTpyYWRlb25fZ2V0X3ZibGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0 IDMKPj4gW2RybTpkcm1fdXBkYXRlX3ZibGFua19jb3VudF0gdXBkYXRpbmcgdmJsYW5rIGNvdW50 IG9uIGNydGMgMTogY3VycmVudD0wLCBkaWZmPTAsIGh3PTAgaHdfbGFzdD0wCj4+IFtkcm06cmFk ZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1ZXJ5IGZhaWxlZCEgc3RhdCAzCj4+IFtkcm06 cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1ZXJ5IGZhaWxlZCEgc3RhdCAzCj4+IFtk cm06ZHJtX3VwZGF0ZV92YmxhbmtfY291bnRdIHVwZGF0aW5nIHZibGFuayBjb3VudCBvbiBjcnRj IDI6IGN1cnJlbnQ9MCwgZGlmZj0wLCBodz0wIGh3X2xhc3Q9MAo+PiBbZHJtOnJhZGVvbl9nZXRf dmJsYW5rX2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+PiBbZHJtOnJhZGVvbl9n ZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+PiBbZHJtOmRybV91 cGRhdGVfdmJsYW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAzOiBjdXJy ZW50PTAsIGRpZmY9MCwgaHc9MCBod19sYXN0PTAKPj4gW2RybTpyYWRlb25fZ2V0X3ZibGFua19j b3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0IDEKPj4gW2RybTpkcm1fY2FsY192Ymx0aW1l c3RhbXBfZnJvbV9zY2Fub3V0cG9zXSBjcnRjIDAgOiB2IDB4MSBwKDAsMClAIDczMDQuMzE3MTQw IC0+IDczMDQuMzE3MTQwIFtlIDAgdXMsIDAgcmVwXQo+PiBbZHJtOnJhZGVvbl9nZXRfdmJsYW5r X2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMQo+PiBbZHJtOmRybV91cGRhdGVfdmJs YW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIzNDg4 MDk5NSwgZGlmZj0xNjc3NzIxNSwgaHc9MCBod19sYXN0PTEKPiAKPiBTYW1lIGhlcmUuCgpBdCBs ZWFzdCBvbmUgb2YgdGhlIGp1bXBzIGlzIGV4cGVjdGVkLCBiZWNhdXNlIHRoaXMgaXMgYXJvdW5k IHR1cm5pbmcKb2ZmIHRoZSBDUlRDIGZvciBEUE1TIG9mZi4gRG9uJ3Qga25vdyB5ZXQgd2h5IHRo ZXJlIGFyZSB0d28ganVtcHMgYmFjawp0aG91Z2guCgoKPiBUaGVzZSB0aGluZ3MganVzdCBkb24n dCBoYXBwZW4gb24gaTkxNSBiZWNhdXNlIGRybV92Ymxhbmtfb2ZmKCkgYW5kCj4gZHJtX3ZibGFu a19vbigpIGFyZSBhbHdheXMgY2FsbGVkIGFyb3VuZCB0aGUgdGltZXMgd2hlbiB0aGUgaHcgY291 bnRlcgo+IG1pZ2h0IGdldCByZXNldC4gT3IgYXQgbGVhc3QgdGhhdCdzIGhvdyBpdCBzaG91bGQg YmUuCgpXaGljaCBpcyBvZiBjb3Vyc2UgdGhlIGlkZWEgb2YgRGFuaWVsJ3MgcGF0Y2ggKHdoaWNo IGlzIHdoYXQgSSdtIGdldHRpbmcKdGhlIGFib3ZlIHdpdGgpIG9yIE1hcmlvJ3MgcGF0Y2ggYXMg d2VsbCwgYnV0IGNsZWFybHkgc29tZXRoaW5nJ3Mgc3RpbGwKd3JvbmcuIEl0J3MgY2VydGFpbmx5 IHBvc3NpYmxlIHRoYXQgaXQncyBzb21ldGhpbmcgaW4gdGhlIGRyaXZlciwgYnV0CnNpbmNlIGNh bGxpbmcgZHJtX3ZibGFua19wcmUvcG9zdF9tb2Rlc2V0IGZyb20gdGhlIHNhbWUgcGxhY2VzIHNl ZW1zIHRvCndvcmsgZmluZSAoaWdub3JpbmcgdGhlIHJlZ3Jlc3Npb24gZGlzY3Vzc2VkIGluIHRo aXMgdGhyZWFkKS4uLiBEbwpkcm1fdmJsYW5rX29uL29mZiByZXF1aXJlIHNvbWV0aGluZyBlbHNl IHRvIGhhbmRsZSB0aGlzIGNvcnJlY3RseT8KCgotLSAKRWFydGhsaW5nIE1pY2hlbCBEw6RuemVy ICAgICAgICAgICAgICAgfCAgICAgICAgICAgICAgIGh0dHA6Ly93d3cuYW1kLmNvbQpMaWJyZSBz b2Z0d2FyZSBlbnRodXNpYXN0ICAgICAgICAgICAgIHwgICAgICAgICAgICAgTWVzYSBhbmQgWCBk ZXZlbG9wZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK