All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: "Rafał Miłecki" <zajec5@gmail.com>,
	"Kalle Valo" <kvalo@codeaurora.org>,
	"Brett Rudley" <brudley@broadcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@broadcom.com>,
	"Hante Meuleman" <meuleman@broadcom.com>,
	linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com
Subject: Re: [PATCH] brcmfmac: advertise frames supported for TX in AP mode
Date: Mon, 25 Jan 2016 10:52:32 +0100	[thread overview]
Message-ID: <56A5F060.6050306@broadcom.com> (raw)
In-Reply-To: <1453295190-28404-1-git-send-email-zajec5@gmail.com>



On 20-1-2016 14:06, Rafał Miłecki wrote:
> Callback mgmt_tx implementation supports both: PROBE_RESP and ACTION.
> 
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> This matches code I can see in brcmf_cfg80211_mgmt_tx, hope it makes
> sense.

As said in another response [1] this function was added for P2P
functionality. Hence I do not feel comfortable adding this patch without
subsequent testing.

Regards,
Arend

[1] http://mid.gmane.org/56A5EFBD.5070400@broadcom.com

> ---
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index ab431e5..8d9cff4 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5948,6 +5948,10 @@ brcmf_txrx_stypes[NUM_NL80211_IFTYPES] = {
>  		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
>  		      BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
>  	},
> +	[NL80211_IFTYPE_AP] = {
> +		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
> +		      BIT(IEEE80211_STYPE_PROBE_RESP >> 4)
> +	},
>  	[NL80211_IFTYPE_P2P_CLIENT] = {
>  		.tx = 0xffff,
>  		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
> 

  reply	other threads:[~2016-01-25  9:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 13:06 [PATCH] brcmfmac: advertise frames supported for TX in AP mode Rafał Miłecki
2016-01-25  9:52 ` Arend van Spriel [this message]
2016-03-16 23:28   ` Julian Calaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A5F060.6050306@broadcom.com \
    --to=arend@broadcom.com \
    --cc=brcm80211-dev-list@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=frankyl@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=meuleman@broadcom.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.