All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: famz@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
	stefanha@redhat.com, den@openvz.org, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension specification
Date: Mon, 25 Jan 2016 13:15:25 +0300	[thread overview]
Message-ID: <56A5F5BD.40501@virtuozzo.com> (raw)
In-Reply-To: <20160119172923.GG4579@noname.redhat.com>

On 19.01.2016 20:29, Kevin Wolf wrote:
> Am 19.01.2016 um 09:57 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> On 19.01.2016 00:16, Eric Blake wrote:
>>> preserving semantics of those extra_data bytes).  We
>>> have enough room for future extension, and that's good e
>> Ok, so, what should go to the spec? Current wording is ok? Just
>> delete "Type-specific":
>>
>> +
>> +        20 - 23:    extra_data_size
>> +                    Size of type-specific extra data.
>> +
>> +                    For now, as no extra data is defined, extra_data_size is
>> +                    reserved and must be zero.
>> +
>> +        variable:   Extra data for the bitmap.
> Please be explicit that if extra_data_size is non-zero, the bitmap must
> not be used (i.e. specify the incompatible-feature-bit-like behaviour).

It is not enough. If there are some unknown extra data, then just 
ignoring this bitmap may lead to its inconsistency. So, if it is 
non-zero, the whole image should not be written. (real 
incompatible-feature-bit behavior).

>
> Kevin


-- 
Best regards,
Vladimir
* now, @virtuozzo.com instead of @parallels.com. Sorry for this inconvenience.

  reply	other threads:[~2016-01-25 10:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 13:05 [Qemu-devel] [PATCH v7] spec: add qcow2 bitmaps extension specification Vladimir Sementsov-Ogievskiy
2016-01-12  0:30 ` John Snow
2016-01-14 11:35   ` Denis V. Lunev
2016-01-14 16:42     ` John Snow
2016-01-14 22:08 ` Eric Blake
2016-01-14 23:26   ` John Snow
2016-01-16 14:06     ` Vladimir Sementsov-Ogievskiy
2016-01-18 16:54       ` John Snow
2016-01-18 21:16         ` Eric Blake
2016-01-19  8:57           ` Vladimir Sementsov-Ogievskiy
2016-01-19 17:29             ` Kevin Wolf
2016-01-25 10:15               ` Vladimir Sementsov-Ogievskiy [this message]
2016-01-25 11:09                 ` Kevin Wolf
2016-01-25 12:27                   ` Vladimir Sementsov-Ogievskiy
2016-01-19 17:27           ` Kevin Wolf
2016-01-25 10:22             ` Vladimir Sementsov-Ogievskiy
2016-01-19 17:48 ` Kevin Wolf
2016-01-20 12:34   ` Vladimir Sementsov-Ogievskiy
2016-01-20 21:22     ` John Snow
2016-01-21  8:22       ` Vladimir Sementsov-Ogievskiy
2016-01-21  9:53         ` Kevin Wolf
2016-01-21 10:44           ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A5F5BD.40501@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.