From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757434AbcAYPgq (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 10:36:46 -0500
Received: from arrakis.dune.hu ([78.24.191.176]:38161 "EHLO arrakis.dune.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754830AbcAYPgo (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 10:36:44 -0500
Subject: Re: [PATCH V2 4/4] mfd: mediatek: add MT6323 support to MT6397 driver
To: Lee Jones <lee.jones@linaro.org>
References: <1453716887-38442-1-git-send-email-blogic@openwrt.org>
 <1453716887-38442-5-git-send-email-blogic@openwrt.org>
 <20160125124112.GG3368@x1>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
        Flora Fu <flora.fu@mediatek.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Henry Chen <henryc.chen@mediatek.com>,
        Steven Liu <steven.liu@mediatek.com>,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
From: John Crispin <blogic@openwrt.org>
Message-ID: <56A64108.7020807@openwrt.org>
Date: Mon, 25 Jan 2016 16:36:40 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160125124112.GG3368@x1>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 25/01/2016 13:41, Lee Jones wrote:
> Please honour the subject format of the subsystem you are contributing
> to.
> 
> `git log --oneline -- $subsystem` gives you this.
> 
> On Mon, 25 Jan 2016, John Crispin wrote:
> 
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> ---


[...]

>> @@ -261,6 +271,15 @@ static int mt6397_probe(struct platform_device *pdev)
>>  	}
>>  
>>  	switch (id & 0xff) {
>> +	case MT6323_CID_CODE:
>> +		mt6397->int_con[0] = MT6323_INT_CON0;
> 
> This is confusing.  You're still using memory allocated for a mt6397
> device.
> 

the variable is currently defined as struct mt6397_chip *mt6397;
shall i only change the name or also create a patch to rename the struct ?

	John

From mboxrd@z Thu Jan  1 00:00:00 1970
From: blogic@openwrt.org (John Crispin)
Date: Mon, 25 Jan 2016 16:36:40 +0100
Subject: [PATCH V2 4/4] mfd: mediatek: add MT6323 support to MT6397 driver
In-Reply-To: <20160125124112.GG3368@x1>
References: <1453716887-38442-1-git-send-email-blogic@openwrt.org>
 <1453716887-38442-5-git-send-email-blogic@openwrt.org>
 <20160125124112.GG3368@x1>
Message-ID: <56A64108.7020807@openwrt.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi,

On 25/01/2016 13:41, Lee Jones wrote:
> Please honour the subject format of the subsystem you are contributing
> to.
> 
> `git log --oneline -- $subsystem` gives you this.
> 
> On Mon, 25 Jan 2016, John Crispin wrote:
> 
>> Signed-off-by: John Crispin <blogic@openwrt.org>
>> ---


[...]

>> @@ -261,6 +271,15 @@ static int mt6397_probe(struct platform_device *pdev)
>>  	}
>>  
>>  	switch (id & 0xff) {
>> +	case MT6323_CID_CODE:
>> +		mt6397->int_con[0] = MT6323_INT_CON0;
> 
> This is confusing.  You're still using memory allocated for a mt6397
> device.
> 

the variable is currently defined as struct mt6397_chip *mt6397;
shall i only change the name or also create a patch to rename the struct ?

	John