From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757364AbcAYPna (ORCPT ); Mon, 25 Jan 2016 10:43:30 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:33174 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752265AbcAYPn1 (ORCPT ); Mon, 25 Jan 2016 10:43:27 -0500 Subject: Re: [Xen-devel] [PATCH v1 02/12] xen/hvmlite: Factor out common kernel init code To: David Vrabel , konrad.wilk@oracle.com References: <1453498558-6028-1-git-send-email-boris.ostrovsky@oracle.com> <1453498558-6028-3-git-send-email-boris.ostrovsky@oracle.com> <56A6012F.1090706@citrix.com> Cc: xen-devel@lists.xenproject.org, mcgrof@suse.com, linux-kernel@vger.kernel.org, roger.pau@citrix.com From: Boris Ostrovsky Message-ID: <56A6425F.4070203@oracle.com> Date: Mon, 25 Jan 2016 10:42:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <56A6012F.1090706@citrix.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2016 06:04 AM, David Vrabel wrote: > On 22/01/16 21:35, Boris Ostrovsky wrote: >> HVMlite guests (to be introduced in subsequent patches) share most >> of the kernel initialization code with PV(H). > Where possible, HVMlite should share initialization with bare metal/HVM > and not PV(H). This is really platform initialization, for HVMlite it's invoked as x86_init.oem.arch_setup(). Things like xen_setup_features(), xen_init_apic() etc. I suppose I can move it to xen_hvm_guest_init() but then we will have some amount of code duplication. There is also a chunk of code there (in xen_init_kernel()) that will probably be used for HVMlite dom0. > > Sharing any code with the existing PVH code isn't useful, since PVH > support will be removed. There is nothing PVH-specific, I said "(H)" mostly because that code is the same is PV. -boris From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v1 02/12] xen/hvmlite: Factor out common kernel init code Date: Mon, 25 Jan 2016 10:42:23 -0500 Message-ID: <56A6425F.4070203@oracle.com> References: <1453498558-6028-1-git-send-email-boris.ostrovsky@oracle.com> <1453498558-6028-3-git-send-email-boris.ostrovsky@oracle.com> <56A6012F.1090706@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aNjHd-0000Kd-DQ for xen-devel@lists.xenproject.org; Mon, 25 Jan 2016 15:42:25 +0000 In-Reply-To: <56A6012F.1090706@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , konrad.wilk@oracle.com Cc: xen-devel@lists.xenproject.org, mcgrof@suse.com, linux-kernel@vger.kernel.org, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 01/25/2016 06:04 AM, David Vrabel wrote: > On 22/01/16 21:35, Boris Ostrovsky wrote: >> HVMlite guests (to be introduced in subsequent patches) share most >> of the kernel initialization code with PV(H). > Where possible, HVMlite should share initialization with bare metal/HVM > and not PV(H). This is really platform initialization, for HVMlite it's invoked as x86_init.oem.arch_setup(). Things like xen_setup_features(), xen_init_apic() etc. I suppose I can move it to xen_hvm_guest_init() but then we will have some amount of code duplication. There is also a chunk of code there (in xen_init_kernel()) that will probably be used for HVMlite dom0. > > Sharing any code with the existing PVH code isn't useful, since PVH > support will be removed. There is nothing PVH-specific, I said "(H)" mostly because that code is the same is PV. -boris