From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v4 07/21] arm/acpi: Print GIC information when MADT is parsed Date: Mon, 25 Jan 2016 07:49:27 -0700 Message-ID: <56A6440702000078000CAB15@prv-mh.provo.novell.com> References: <1453540813-15764-1-git-send-email-zhaoshenglong@huawei.com> <1453540813-15764-8-git-send-email-zhaoshenglong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453540813-15764-8-git-send-email-zhaoshenglong@huawei.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Shannon Zhao Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, peter.huangpeng@huawei.com, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, shannon.zhao@linaro.org List-Id: xen-devel@lists.xenproject.org >>> On 23.01.16 at 10:19, wrote: > From: Shannon Zhao > > When MADT is parsed, print GIC information to make the boot log look > pretty. > > Signed-off-by: Hanjun Guo > Signed-off-by: Tomasz Nowicki > Signed-off-by: Shannon Zhao Is this the equivalent of a Linux side commit? If so please name it. If not, ... > --- a/xen/drivers/acpi/tables.c > +++ b/xen/drivers/acpi/tables.c > @@ -189,6 +189,28 @@ void __init acpi_table_print_madt_entry(struct acpi_subtable_header *header) > } > break; > > + case ACPI_MADT_TYPE_GENERIC_INTERRUPT: > + { > + struct acpi_madt_generic_interrupt *p = > + (struct acpi_madt_generic_interrupt *)header; ... no matter that other cases here have been coded in a similarly bad manner, please do better than them and use container_of() instead of a cast here. (Cleaning up the others is [fairly low] on my todo list.) Jan