From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNmbB-0006Hq-MM for qemu-devel@nongnu.org; Mon, 25 Jan 2016 14:14:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNmb7-0003V6-N9 for qemu-devel@nongnu.org; Mon, 25 Jan 2016 14:14:49 -0500 References: <1453684527-23564-1-git-send-email-david@gibson.dropbear.id.au> <1453684527-23564-2-git-send-email-david@gibson.dropbear.id.au> From: Alexander Graf Message-ID: <56A67420.7070202@suse.de> Date: Mon, 25 Jan 2016 20:14:40 +0100 MIME-Version: 1.0 In-Reply-To: <1453684527-23564-2-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , peter.maydell@linaro.org Cc: lvivier@redhat.com, thuth@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, gkurz@linux.vnet.ibm.com On 01/25/2016 02:15 AM, David Gibson wrote: > From: Benjamin Herrenschmidt > > We never released anything older than POWER8 DD2.0 and POWER8E DD2.1, > so let's use these versions, without that some firmware or Linux code > might fail to use some HW features that were non functional in earlier > internal only spins of the chip. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: David Gibson > --- > target-ppc/cpu-models.c | 12 ++++++------ > target-ppc/cpu-models.h | 4 ++-- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c > index 4d5ab4b..349783e 100644 > --- a/target-ppc/cpu-models.c > +++ b/target-ppc/cpu-models.c > @@ -1138,10 +1138,10 @@ > "POWER7 v2.3") > POWERPC_DEF("POWER7+_v2.1", CPU_POWERPC_POWER7P_v21, POWER7, > "POWER7+ v2.1") > - POWERPC_DEF("POWER8E_v1.0", CPU_POWERPC_POWER8E_v10, POWER8, > - "POWER8E v1.0") > - POWERPC_DEF("POWER8_v1.0", CPU_POWERPC_POWER8_v10, POWER8, > - "POWER8 v1.0") Removing those breaks -cpu host on 1.0 machines, no? Alex > + POWERPC_DEF("POWER8E_v2.1", CPU_POWERPC_POWER8E_v21, POWER8, > + "POWER8E v2.1") > + POWERPC_DEF("POWER8_v2.0", CPU_POWERPC_POWER8_v20, POWER8, > + "POWER8 v2.0") > POWERPC_DEF("970_v2.2", CPU_POWERPC_970_v22, 970, > "PowerPC 970 v2.2") > POWERPC_DEF("970fx_v1.0", CPU_POWERPC_970FX_v10, 970, > @@ -1389,8 +1389,8 @@ PowerPCCPUAlias ppc_cpu_aliases[] = { > { "POWER5gs", "POWER5+_v2.1" }, > { "POWER7", "POWER7_v2.3" }, > { "POWER7+", "POWER7+_v2.1" }, > - { "POWER8E", "POWER8E_v1.0" }, > - { "POWER8", "POWER8_v1.0" }, > + { "POWER8E", "POWER8E_v2.1" }, > + { "POWER8", "POWER8_v2.0" }, > { "970", "970_v2.2" }, > { "970fx", "970fx_v3.1" }, > { "970mp", "970mp_v1.1" }, > diff --git a/target-ppc/cpu-models.h b/target-ppc/cpu-models.h > index 9d80e72..2992427 100644 > --- a/target-ppc/cpu-models.h > +++ b/target-ppc/cpu-models.h > @@ -557,9 +557,9 @@ enum { > CPU_POWERPC_POWER7P_BASE = 0x004A0000, > CPU_POWERPC_POWER7P_v21 = 0x004A0201, > CPU_POWERPC_POWER8E_BASE = 0x004B0000, > - CPU_POWERPC_POWER8E_v10 = 0x004B0100, > + CPU_POWERPC_POWER8E_v21 = 0x004B0201, > CPU_POWERPC_POWER8_BASE = 0x004D0000, > - CPU_POWERPC_POWER8_v10 = 0x004D0100, > + CPU_POWERPC_POWER8_v20 = 0x004D0200, > CPU_POWERPC_970_v22 = 0x00390202, > CPU_POWERPC_970FX_v10 = 0x00391100, > CPU_POWERPC_970FX_v20 = 0x003C0200,