From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48506) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNmmH-0002c4-R4 for qemu-devel@nongnu.org; Mon, 25 Jan 2016 14:26:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNmmD-0006Mi-U6 for qemu-devel@nongnu.org; Mon, 25 Jan 2016 14:26:17 -0500 References: <1453684527-23564-1-git-send-email-david@gibson.dropbear.id.au> <1453684527-23564-2-git-send-email-david@gibson.dropbear.id.au> <56A67420.7070202@suse.de> From: Thomas Huth Message-ID: <56A676CF.1060508@redhat.com> Date: Mon, 25 Jan 2016 20:26:07 +0100 MIME-Version: 1.0 In-Reply-To: <56A67420.7070202@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , David Gibson , peter.maydell@linaro.org Cc: lvivier@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, gkurz@linux.vnet.ibm.com On 25.01.2016 20:14, Alexander Graf wrote: >=20 >=20 > On 01/25/2016 02:15 AM, David Gibson wrote: >> From: Benjamin Herrenschmidt >> >> We never released anything older than POWER8 DD2.0 and POWER8E DD2.1, >> so let's use these versions, without that some firmware or Linux code >> might fail to use some HW features that were non functional in earlier >> internal only spins of the chip. >> >> Signed-off-by: Benjamin Herrenschmidt >> Signed-off-by: David Gibson >> --- >> target-ppc/cpu-models.c | 12 ++++++------ >> target-ppc/cpu-models.h | 4 ++-- >> 2 files changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c >> index 4d5ab4b..349783e 100644 >> --- a/target-ppc/cpu-models.c >> +++ b/target-ppc/cpu-models.c >> @@ -1138,10 +1138,10 @@ >> "POWER7 v2.3") >> POWERPC_DEF("POWER7+_v2.1", CPU_POWERPC_POWER7P_v21, =20 >> POWER7, >> "POWER7+ v2.1") >> - POWERPC_DEF("POWER8E_v1.0", CPU_POWERPC_POWER8E_v10, =20 >> POWER8, >> - "POWER8E v1.0") >> - POWERPC_DEF("POWER8_v1.0", CPU_POWERPC_POWER8_v10, =20 >> POWER8, >> - "POWER8 v1.0") >=20 > Removing those breaks -cpu host on 1.0 machines, no? I don't think so. The code in kvm_ppc_register_host_cpu_type() explicitly registers a "host" CPU type with the PVR of the current host. Apart from that, as mentioned in the patch description, v1.0 chips apparently have never been released into the wild - and I guess the unreleased v1.0 chips have all already scrapped nowadays ... so the patch should be fine, I think. Thomas