From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNndD-00054N-RH for qemu-devel@nongnu.org; Mon, 25 Jan 2016 15:21:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNndB-0001O1-5l for qemu-devel@nongnu.org; Mon, 25 Jan 2016 15:20:59 -0500 References: <1453684527-23564-1-git-send-email-david@gibson.dropbear.id.au> <1453684527-23564-2-git-send-email-david@gibson.dropbear.id.au> <56A67420.7070202@suse.de> <56A676CF.1060508@redhat.com> From: Alexander Graf Message-ID: <56A683A7.8080808@suse.de> Date: Mon, 25 Jan 2016 21:20:55 +0100 MIME-Version: 1.0 In-Reply-To: <56A676CF.1060508@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , David Gibson , peter.maydell@linaro.org Cc: lvivier@redhat.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, bharata@linux.vnet.ibm.com, gkurz@linux.vnet.ibm.com On 01/25/2016 08:26 PM, Thomas Huth wrote: > On 25.01.2016 20:14, Alexander Graf wrote: >> >> On 01/25/2016 02:15 AM, David Gibson wrote: >>> From: Benjamin Herrenschmidt >>> >>> We never released anything older than POWER8 DD2.0 and POWER8E DD2.1, >>> so let's use these versions, without that some firmware or Linux code >>> might fail to use some HW features that were non functional in earlier >>> internal only spins of the chip. >>> >>> Signed-off-by: Benjamin Herrenschmidt >>> Signed-off-by: David Gibson >>> --- >>> target-ppc/cpu-models.c | 12 ++++++------ >>> target-ppc/cpu-models.h | 4 ++-- >>> 2 files changed, 8 insertions(+), 8 deletions(-) >>> >>> diff --git a/target-ppc/cpu-models.c b/target-ppc/cpu-models.c >>> index 4d5ab4b..349783e 100644 >>> --- a/target-ppc/cpu-models.c >>> +++ b/target-ppc/cpu-models.c >>> @@ -1138,10 +1138,10 @@ >>> "POWER7 v2.3") >>> POWERPC_DEF("POWER7+_v2.1", CPU_POWERPC_POWER7P_v21, >>> POWER7, >>> "POWER7+ v2.1") >>> - POWERPC_DEF("POWER8E_v1.0", CPU_POWERPC_POWER8E_v10, >>> POWER8, >>> - "POWER8E v1.0") >>> - POWERPC_DEF("POWER8_v1.0", CPU_POWERPC_POWER8_v10, >>> POWER8, >>> - "POWER8 v1.0") >> Removing those breaks -cpu host on 1.0 machines, no? > I don't think so. The code in kvm_ppc_register_host_cpu_type() > explicitly registers a "host" CPU type with the PVR of the current host. Ah, right, it used to only search for a fitting one, but I think we changed it to account for cpu families. So all is safe :). Alex