From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 3/5 RFC] ARM: bcm283x: specify sdhci quirks in dtsi file Date: Mon, 25 Jan 2016 21:31:11 -0700 Message-ID: <56A6F68F.7030801@wwwdotorg.org> References: <1453042744-16196-1-git-send-email-stefan.wahren@i2se.com> <1453042744-16196-4-git-send-email-stefan.wahren@i2se.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453042744-16196-4-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stefan Wahren Cc: Scott Branden , Ray Jui , Jon Mason , Lee Jones , Eric Anholt , Rob Herring , Mark Rutland , Arnd Bergmann , Ulf Hansson , kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On 01/17/2016 07:59 AM, Stefan Wahren wrote: > This patch defines the known quirks for BCM283x in the dtsi file: > * SDHCI_QUIRK_BROKEN_CARD_DETECTION > * SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 > > So we don't need to define them in the driver. Given that the quirks are currently defined in the driver, I believe they will forever have to be defined in the driver. If the (or a different) driver suddenly starts requiring the DT to specify the quirks, then old DTs won't work with a new kernel, which is against DT ABI. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html