From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO5kv-0000ZH-FY for qemu-devel@nongnu.org; Tue, 26 Jan 2016 10:42:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO5ks-0005VH-4x for qemu-devel@nongnu.org; Tue, 26 Jan 2016 10:42:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO5kr-0005V5-VV for qemu-devel@nongnu.org; Tue, 26 Jan 2016 10:42:06 -0500 References: <1453710287-12706-1-git-send-email-valentin.rakush@gmail.com> <20160126153538.GN3869@thinpad.lan.raisama.net> From: Eric Blake Message-ID: <56A793CB.3030400@redhat.com> Date: Tue, 26 Jan 2016 08:42:03 -0700 MIME-Version: 1.0 In-Reply-To: <20160126153538.GN3869@thinpad.lan.raisama.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GfWT8RbcloMk1voOKUThgSHnM7d7A54kd" Subject: Re: [Qemu-devel] [PATCH v5] qom, qmp, hmp, qapi: create qom-type-prop-list for class properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , Valentin Rakush Cc: armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, asmetanin@virtuozzo.com, den@openvz.org, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GfWT8RbcloMk1voOKUThgSHnM7d7A54kd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/26/2016 08:35 AM, Eduardo Habkost wrote: > On Mon, Jan 25, 2016 at 11:24:47AM +0300, Valentin Rakush wrote: >> This patch adds support for qom-type-prop-list command to list object >> class properties. A later patch will use this functionality to >> implement x86_64-cpu properties. >> >=20 > We already have "-device ,help", and it uses a completely > different mechanism for listing properties. There's no reason for > having two arbitrarily different APIs for listing properties > returning different results. And the QMP counterpart of '-device ,help' is 'device-list-properties'. >=20 > If qmp_device_list_properties() is not enough for you, please > clarify why, so we can consider improving it. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GfWT8RbcloMk1voOKUThgSHnM7d7A54kd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWp5PLAAoJEKeha0olJ0NqWdIH/2j9tCYRZeg//bskSmJQN+kg uZ4Qtx18g4A7CJpdl9q+rfpD4rrh3vA2bnxE4jSGVa/WYcGTcTvBr3ltsZIxi326 mcrHbdIWS0kW2TJLZqqXIs/QhOlna1KBAgWWBfnK9osNr8onK4xRUiMmTmnUHS60 OJ8NX+StoiFaZfnMVaLvrM3RPjZYcsD98w/hp1gmpGhiESQ8k3fEB9KzuWg/KJ1J 0UyinN5FyJIkP+GVOGipyIRid4GhvJLF+RPXf5frIlw4IiNcR5M2CGhn7s96DI3t 7srK2z3TUyAq2WGtH6LMEQl3WbQfoOLBidppBIoGzQD7A0o+zrt5YypnSob7bGg= =yYZU -----END PGP SIGNATURE----- --GfWT8RbcloMk1voOKUThgSHnM7d7A54kd--