From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 07522E00C12; Wed, 27 Jan 2016 04:11:08 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 SPF_HELO_PASS SPF: HELO matches SPF record * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from ptmx.org (ptmx.org [178.63.28.110]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id DC8BBE0086B for ; Wed, 27 Jan 2016 04:11:03 -0800 (PST) Received: from [10.1.14.248] (vpn.streamunlimited.com [91.114.0.140]) by ptmx.org (Postfix) with ESMTPSA id 0C3CC2376F for ; Wed, 27 Jan 2016 13:11:02 +0100 (CET) To: meta-freescale@yoctoproject.org References: <1453887720-16863-1-git-send-email-b54851@freescale.com> <1453887720-16863-9-git-send-email-b54851@freescale.com> From: Carlos Rafael Giani Message-ID: <56A8B3D5.4020800@pseudoterminal.org> Date: Wed, 27 Jan 2016 13:11:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1453887720-16863-9-git-send-email-b54851@freescale.com> Subject: Re: [meta-fsl-arm][PATCH 8/9] gstreamer1.0-plugins-bad: Fix gleffects fisheye shader compile error X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2016 12:11:08 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit This commit is acceptable. I can also live with the "i.MX specific" part, since this is a Vivante GPU problem. I think this could be upstreamed, though, because having "sqrt(2)" in the shader does not actually gain anybody anything. It would be perfectly acceptable to replace it with 1.414213562 instead. I recommend posting this to GStreamer bugzilla. On 01/27/2016 10:41 AM, Yuqing Zhu wrote: > shader function "sqrt" is not support, use float number 1.414 > > Signed-off-by: Yuqing Zhu > --- > ...-glplugin-fix-gleffects-fisheye-shader-co.patch | 31 ++++++++++++++++++++++ > .../gstreamer/gstreamer1.0-plugins-bad_%.bbappend | 1 + > 2 files changed, 32 insertions(+) > create mode 100755 recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-fix-gleffects-fisheye-shader-co.patch > > diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-fix-gleffects-fisheye-shader-co.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-fix-gleffects-fisheye-shader-co.patch > new file mode 100755 > index 0000000..d017a1f > --- /dev/null > +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0009-glplugin-fix-gleffects-fisheye-shader-co.patch > @@ -0,0 +1,31 @@ > +From de919fc1cf4250db240757a94f302d81620b451c Mon Sep 17 00:00:00 2001 > +From: Haihua Hu > +Date: Tue, 8 Dec 2015 14:09:58 +0800 > +Subject: [PATCH 5/5] [MMFMWK-6966] [glplugin] fix gleffects fisheye shader > + compile error > + > +shader function "sqrt" is not support, use float number 1.414 > + > +Upstream-Status: Inappropriate [i.MX specific] > + > +Signed-off-by: Haihua Hu > +--- > + ext/gl/effects/gstgleffectssources.c | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/ext/gl/effects/gstgleffectssources.c b/ext/gl/effects/gstgleffectssources.c > +index 3da856c..076e21b 100644 > +--- a/ext/gl/effects/gstgleffectssources.c > ++++ b/ext/gl/effects/gstgleffectssources.c > +@@ -152,7 +152,7 @@ const gchar *fisheye_fragment_source_gles2 = > + " vec2 normcoord;" > + " normcoord = texturecoord - 0.5;" > + " float r = length (normcoord);" > +- " normcoord *= r * sqrt(2);" > ++ " normcoord *= r * 1.414;" > + " texturecoord = normcoord + 0.5;" > + " gl_FragColor = texture2D (tex, texturecoord);" > + "}"; > +-- > +1.7.9.5 > + > diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend > index d3b8c2d..ce8a158 100644 > --- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend > +++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend > @@ -18,6 +18,7 @@ IMX_PATCHES = " file://0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h > file://0006-glplugin-Support-fb-backend-for-gl-plugins.patch \ > file://0007-glplugin-Change-wayland-default-res-to-1024x768.patch \ > file://0008-glplugin-Add-fps-print-in-glimagesink.patch \ > + file://0009-glplugin-fix-gleffects-fisheye-shader-co.patch \ > " > > SRC_URI_append_mx6 = "${IMX_PATCHES}"