From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aOP1L-0008P4-1I
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 07:16:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1aOP1G-0005fY-F8
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 07:16:22 -0500
References: <1453889591-30968-1-git-send-email-david@gibson.dropbear.id.au>
	<1453889591-30968-2-git-send-email-david@gibson.dropbear.id.au>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <56A8B508.1080703@redhat.com>
Date: Wed, 27 Jan 2016 13:16:08 +0100
MIME-Version: 1.0
In-Reply-To: <1453889591-30968-2-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2 01/10] target-ppc: Remove unused
 kvmppc_read_segment_page_sizes() stub
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>, benh@kernel.crashing.org
Cc: aik@ozlabs.ru, lvivier@redhat.com, qemu-ppc@nongnu.org, agraf@suse.de, qemu-devel@nongnu.org

On 27.01.2016 11:13, David Gibson wrote:
> This stub function is in the !KVM ifdef in target-ppc/kvm_ppc.h.  However
> no such function exists on the KVM side, or is ever used.
> 
> I think this originally referenced a function which read host page size
> information from /proc, for we we now use the KVM GET_SMMU_INFO extension
> instead.
> 
> In any case, it has no function now, so remove it.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  target-ppc/kvm_ppc.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/target-ppc/kvm_ppc.h b/target-ppc/kvm_ppc.h
> index 5e1333d..62406ce 100644
> --- a/target-ppc/kvm_ppc.h
> +++ b/target-ppc/kvm_ppc.h
> @@ -98,11 +98,6 @@ static inline int kvmppc_get_hypercall(CPUPPCState *env, uint8_t *buf, int buf_l
>      return -1;
>  }
>  
> -static inline int kvmppc_read_segment_page_sizes(uint32_t *prop, int maxcells)
> -{
> -    return -1;
> -}
> -
>  static inline int kvmppc_set_interrupt(PowerPCCPU *cpu, int irq, int level)
>  {
>      return -1;

Reviewed-by: Thomas Huth <thuth@redhat.com>