From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966368AbcA1CN7 (ORCPT ); Wed, 27 Jan 2016 21:13:59 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:26835 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934283AbcA1CN5 (ORCPT ); Wed, 27 Jan 2016 21:13:57 -0500 Subject: Re: [PATCH 15/15] Revert "of/platform: export of_default_bus_match_table" To: Hauke Mehrtens , , References: <1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com> <1453868872-26300-16-git-send-email-wangkefeng.wang@huawei.com> <56A9404A.7050900@hauke-m.de> CC: Arnd Bergmann , Shawn Guo , "Russell King" , Catalin Marinas , Rob Herring , Masahiro Yamada , , Frank Rowand , Grant Likely From: Kefeng Wang Message-ID: <56A978DA.8020404@huawei.com> Date: Thu, 28 Jan 2016 10:11:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56A9404A.7050900@hauke-m.de> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.180] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.56A9791E.0018,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: bab474860c124b05e8492225f8aa03d7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hauke, On 2016/1/28 6:10, Hauke Mehrtens wrote: > On 01/27/2016 05:27 AM, Kefeng Wang wrote: >> This reverts commit b80443c2211c7daaabd20fbbe9e7beb3fa3408e0. >> >> After covering to use helper of_platform_default_populate() to populate >> the default bus, no need to export of_default_bus_match_table anymore. >> >> Cc: Masahiro Yamada >> Cc: Rob Herring >> Cc: Frank Rowand >> Cc: Grant Likely >> Signed-off-by: Kefeng Wang >> --- >> drivers/of/platform.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >> index 8d103e4..af98343 100644 >> --- a/drivers/of/platform.c >> +++ b/drivers/of/platform.c >> @@ -31,7 +31,6 @@ const struct of_device_id of_default_bus_match_table[] = { >> #endif /* CONFIG_ARM_AMBA */ >> {} /* Empty terminated list */ >> }; >> -EXPORT_SYMBOL(of_default_bus_match_table); >> >> static int of_dev_node_match(struct device *dev, void *data) >> { >> > > Is of_default_bus_match_table still accessed or can it be made static > and the header file entry removed? Thanks for your review. There is still a user in drivers/memory/omap-gpmc.c, but it(OMAP_GPMC) only can be selected by ARCH_OMAP2PLUS, keep of_default_bus_match_table in header file. > > Thanks for cleaning up all the drivers, I just needed it for one driver. > > Hauke > > . > From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangkefeng.wang@huawei.com (Kefeng Wang) Date: Thu, 28 Jan 2016 10:11:38 +0800 Subject: [PATCH 15/15] Revert "of/platform: export of_default_bus_match_table" In-Reply-To: <56A9404A.7050900@hauke-m.de> References: <1453868872-26300-1-git-send-email-wangkefeng.wang@huawei.com> <1453868872-26300-16-git-send-email-wangkefeng.wang@huawei.com> <56A9404A.7050900@hauke-m.de> Message-ID: <56A978DA.8020404@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Hauke, On 2016/1/28 6:10, Hauke Mehrtens wrote: > On 01/27/2016 05:27 AM, Kefeng Wang wrote: >> This reverts commit b80443c2211c7daaabd20fbbe9e7beb3fa3408e0. >> >> After covering to use helper of_platform_default_populate() to populate >> the default bus, no need to export of_default_bus_match_table anymore. >> >> Cc: Masahiro Yamada >> Cc: Rob Herring >> Cc: Frank Rowand >> Cc: Grant Likely >> Signed-off-by: Kefeng Wang >> --- >> drivers/of/platform.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c >> index 8d103e4..af98343 100644 >> --- a/drivers/of/platform.c >> +++ b/drivers/of/platform.c >> @@ -31,7 +31,6 @@ const struct of_device_id of_default_bus_match_table[] = { >> #endif /* CONFIG_ARM_AMBA */ >> {} /* Empty terminated list */ >> }; >> -EXPORT_SYMBOL(of_default_bus_match_table); >> >> static int of_dev_node_match(struct device *dev, void *data) >> { >> > > Is of_default_bus_match_table still accessed or can it be made static > and the header file entry removed? Thanks for your review. There is still a user in drivers/memory/omap-gpmc.c, but it(OMAP_GPMC) only can be selected by ARCH_OMAP2PLUS, keep of_default_bus_match_table in header file. > > Thanks for cleaning up all the drivers, I just needed it for one driver. > > Hauke > > . >