From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47103)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aOcDp-0007Hm-U9
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 21:22:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aOcDm-0006A7-Lp
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 21:22:09 -0500
Received: from [59.151.112.132] (port=25455 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiecl.fnst@cn.fujitsu.com>) id 1aOcDm-00067U-9x
	for qemu-devel@nongnu.org; Wed, 27 Jan 2016 21:22:06 -0500
Message-ID: <56A97B78.5020203@cn.fujitsu.com>
Date: Thu, 28 Jan 2016 10:22:48 +0800
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1452676712-24239-1-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<1452676712-24239-5-git-send-email-xiecl.fnst@cn.fujitsu.com>
	<20160127140402.GK26163@stefanha-x1.localdomain>
In-Reply-To: <20160127140402.GK26163@stefanha-x1.localdomain>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v14 4/8] Allow creating backup jobs when
	opening BDS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>, fnstml-hwcolo@cn.fujitsu.com, qemu devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Paolo Bonzini <pbonzini@redhat.com>

On 01/27/2016 10:04 PM, Stefan Hajnoczi wrote:
> On Wed, Jan 13, 2016 at 05:18:28PM +0800, Changlong Xie wrote:
>> From: Wen Congyang <wency@cn.fujitsu.com>
>>
>> When opening BDS, we need to create backup jobs for
>> image-fleecing.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Reviewed-by: Jeff Cody <jcody@redhat.com>
>> ---
>>   block/Makefile.objs | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/Makefile.objs b/block/Makefile.objs
>> index 58ef2ef..fa05f37 100644
>> --- a/block/Makefile.objs
>> +++ b/block/Makefile.objs
>> @@ -22,10 +22,10 @@ block-obj-$(CONFIG_ARCHIPELAGO) += archipelago.o
>>   block-obj-$(CONFIG_LIBSSH2) += ssh.o
>>   block-obj-y += accounting.o
>>   block-obj-y += write-threshold.o
>> +block-obj-y += backup.o
>>
>>   common-obj-y += stream.o
>>   common-obj-y += commit.o
>> -common-obj-y += backup.o
>>
>>   iscsi.o-cflags     := $(LIBISCSI_CFLAGS)
>>   iscsi.o-libs       := $(LIBISCSI_LIBS)
>
> The commit message and description seem outdated.  I guess the purpose
> of this patch is to link the backup block job into all programs that use
> the block layer because you want to add a dependency on the it from core
> code.
>

Will update it in next version.

Thanks
	-Xie