All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamil Rytarowski <krytarowski@caviumnetworks.com>
To: Panu Matilainen <pmatilai@redhat.com>,
	Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v6 1/2] tools: Add support for handling built-in kernel modules
Date: Thu, 28 Jan 2016 13:54:05 +0100	[thread overview]
Message-ID: <56AA0F6D.3080702@caviumnetworks.com> (raw)
In-Reply-To: <56A9F9EB.4090906@redhat.com>



W dniu 28.01.2016 o 12:22, Panu Matilainen pisze:
> On 01/28/2016 01:17 PM, Kamil Rytarowski wrote:
>> I retained the logic for special case of vfio-pci. At the moment
>> (according to my knowledge) there are no other DPDK modules with this
>> name replacement.
>>
>> I checked few example Linux modules and if a module is named with dash,
>> it's being replaced to underscore. The modprobe(8) tool can accept both
>> names as interchangeable (with dash and underscore).
>>
>> Would you like to make it a general rule and replace all dashes with
>> underscores?
>
> It would be nice to behave the same as modprobe wrt dash and 
> underscore, yes.
>
>     - Panu -
>

My patch is intended to support built-in modules, the rest isn't that 
trivial without changing the behavior.

I prototyped it and it added extra unnecessary complexity, while we just 
want to handle vfio_pci -> vfio-pci.

I'm going to submit new version with improved comment in the code. 
Please continue possible improvements in separate threads.

  reply	other threads:[~2016-01-28 12:54 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1449499771-31466-1-git-send-email-Kamil.Rytarowski@caviumnetworks.com>
2015-12-07 16:57 ` [PATCH v2 1/2] tools: Add support for handling built-in kernel modules Kamil Rytarowski
2015-12-07 16:57   ` [PATCH v2 2/2] eal/linux: " Kamil Rytarowski
2015-12-07 17:14     ` David Marchand
2015-12-07 18:36   ` [PATCH v3 1/2] tools: " Kamil Rytarowski
2015-12-07 18:36     ` [PATCH v3 2/2] eal/linux: " Kamil Rytarowski
2015-12-07 20:45       ` David Marchand
2015-12-07 20:55       ` Stephen Hemminger
2015-12-08  7:25         ` Panu Matilainen
2015-12-08 13:08           ` Kamil Rytarowski
2015-12-08 15:33     ` [PATCH v4 1/2] tools: " Kamil Rytarowski
2015-12-08 15:33       ` [PATCH v4 2/2] eal/linux: " Kamil Rytarowski
2015-12-09  7:30         ` Panu Matilainen
2015-12-09 13:28           ` Kamil Rytarowski
2015-12-09 13:19       ` [PATCH v5 1/2] tools: " Kamil Rytarowski
2015-12-09 13:19         ` [PATCH v5 2/2] eal/linux: " Kamil Rytarowski
2015-12-09 16:38           ` Stephen Hemminger
2015-12-09 16:45             ` Kamil Rytarowski
2016-01-18 14:22           ` Yuanhan Liu
2016-01-19 16:38             ` Kamil Rytarowski
2015-12-16 14:14         ` [PATCH v5 1/2] tools: " Kamil Rytarowski
2016-01-18  9:26           ` Kamil Rytarowski
2016-01-18 14:21         ` Yuanhan Liu
2016-01-19 16:34           ` Kamil Rytarowski
2016-01-18 14:32         ` Thomas Monjalon
2016-01-19 16:35           ` Kamil Rytarowski
2016-01-26 15:12             ` Thomas Monjalon
2016-01-28 11:16               ` Kamil Rytarowski
2016-01-20  9:48         ` [PATCH v6 " krytarowski
2016-01-20  9:48           ` [PATCH v6 2/2] eal/linux: " krytarowski
2016-01-26  9:31           ` [PATCH v6 1/2] tools: " Kamil Rytarowski
2016-01-26 15:23           ` Thomas Monjalon
2016-01-28 11:17             ` Kamil Rytarowski
2016-01-28 11:22               ` Panu Matilainen
2016-01-28 12:54                 ` Kamil Rytarowski [this message]
2016-01-28 13:52               ` Thomas Monjalon
2016-01-28 15:33                 ` Kamil Rytarowski
2016-01-28 13:13           ` [PATCH v7 " krytarowski
2016-01-28 13:13             ` [PATCH v7 2/2] eal/linux: " krytarowski
2016-02-09 14:56               ` Thomas Monjalon
2016-02-09 16:07                 ` Kamil Rytarowski
2016-01-29  7:21             ` [PATCH v7 1/2] tools: " Yuanhan Liu
2016-02-08 22:14               ` Kamil Rytarowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56AA0F6D.3080702@caviumnetworks.com \
    --to=krytarowski@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.