From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v4 19/21] arm/acpi: Initialize serial port
 from ACPI SPCR table
Date: Thu, 28 Jan 2016 05:59:29 -0700
Message-ID: <56AA1EC102000078000CC02F@prv-mh.provo.novell.com>
References: <1453540813-15764-1-git-send-email-zhaoshenglong@huawei.com>
	<1453540813-15764-20-git-send-email-zhaoshenglong@huawei.com>
	<56A647CC02000078000CAB41@prv-mh.provo.novell.com>
	<56AA0A9B.7090304@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56AA0A9B.7090304@huawei.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Shannon Zhao <zhaoshenglong@huawei.com>
Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, peter.huangpeng@huawei.com, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, shannon.zhao@linaro.org
List-Id: xen-devel@lists.xenproject.org

>>> On 28.01.16 at 13:33, <zhaoshenglong@huawei.com> wrote:
> On 2016/1/25 23:05, Jan Beulich wrote:
>>>>> On 23.01.16 at 10:20, <zhaoshenglong@huawei.com> wrote:
>>> --- a/xen/include/acpi/actbl2.h
>>> +++ b/xen/include/acpi/actbl2.h
>>> @@ -815,6 +815,15 @@ struct acpi_table_spcr {
>>>  
>>>  #define ACPI_SPCR_DO_NOT_DISABLE    (1)
>>>  
>>> +/* SPCR Interface type */
>>> +#define ACPI_SPCR_TYPE_16550		0
>>> +#define ACPI_SPCR_TYPE_16550_SUB	0x1
>>> +#define ACPI_SPCR_TYPE_PL011		0x3
>>> +#define ACPI_SPCR_TYPE_SBSA_32		0xd
>>> +#define ACPI_SPCR_TYPE_SBSA		0xe
>>> +#define ACPI_SPCR_TYPE_DCC		0xf
>>> +#define ACPI_SPCR_TYPE_BCM2835		0x10
>> 
>> It seems very likely to me that this part of the change actually would
>> have a Linux counterpart, in which case it should be submitted as such.
>> 
> 
> I checked it with Linux master. Those interface types are shared with
> DGB2 table. But Linux master only adds ACPI_DBG2_16550_COMPATIBLE and
> ACPI_DBG2_16550_SUBSET, doesn't have other types. And actually we only
> need the interface type not the DBG2 table. Yes, it could port commit
> [1] first then add other types. Is that fine?

Yes please.

Jan