From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Margetson Subject: Re: [BUG/REGRESSION] Kernel 4.5-rc1 on Acube Sam460ex AMCC 460ex Power PC motherboards Date: Thu, 28 Jan 2016 14:21:48 -0400 Message-ID: <56AA5C3C.1060001@candw.ms> References: <55592246.5090505@candw.ms> <555A25D7.7070000@candw.ms> <56815C0F.4010207@candw.ms> <56A173FA.2090405@candw.ms> <56A1E59B.5060200@vodafone.de> <56A6190D.3090609@candw.ms> <56A68702.5040909@candw.ms> <56A8997B.3090400@candw.ms> <56A9F055.6000400@candw.ms> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1513414553==" Return-path: Received: from smtp618.redcondor.net (smtp618.redcondor.net [208.80.206.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC29F6E8B0 for ; Thu, 28 Jan 2016 10:22:11 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Williams Cc: Dave Hansen , Maling list - DRI developers , Alex Perez , Christian Zigotzky List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1513414553== Content-Type: multipart/alternative; boundary="------------060108090406010106030807" This is a multi-part message in MIME format. --------------060108090406010106030807 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 1/28/2016 11:47 AM, Dan Williams wrote: > On Thu, Jan 28, 2016 at 2:41 AM, Julian Margetson wr= ote: >> On 1/27/2016 3:34 PM, Dan Williams wrote: >>> On Wed, Jan 27, 2016 at 2:18 AM, Julian Margetson >>> wrote: >>>> On 1/26/2016 9:43 PM, Dan Williams wrote: >>>> diff --git a/mm/memory.c b/mm/memory.c >>>> index 30991f83d0bf..c44e387130b2 100644 >>>> --- a/mm/memory.c >>>> +++ b/mm/memory.c >>>> @@ -1521,6 +1521,8 @@ static int insert_pfn(struct vm_area_struct >>>> *vma, unsigned long addr, >>>> entry =3D pte_mkdevmap(pfn_t_pte(pfn, prot)); >>>> else >>>> entry =3D pte_mkspecial(pfn_t_pte(pfn, prot)); >>>> + pr_info("%s: entry: %#llx pfn: %#lx\n", __func__, >>>> + (unsigned long long) entry, pfn_t_to_pfn(pfn= )); >>>> set_pte_at(mm, addr, pte, entry); >>>> update_mmu_cache(vma, addr, pte); /* XXX: why not for >>>> insert_page? */ >>>> >>>> ...of course for the passing case you'll need to drop the call to >>>> pfn_t_to_pfn() and just print the pfn directly. >>>> >>>> Thank you for the help tracking this down, it's much appreciated. >>>> >>>> Happy to help out. Just need some guidance sometimes as I am relativ= ely >>>> new >>>> at this. >>> No worries. >>> >>> So, below is the failing case, what does insert_pfn print in the >>> passing case? No need for the full log just the first few lines afte= r >>> starting X when running the commit before this failing one... (commit >>> 69660fd797c3 "x86, mm: introduce _PAGE_DEVMAP"). >>> >>> I'm still stumped given that PTE_RPN_SHIFT=3D=3DPAGE_SHIFT in this >>> configuration, so there's no 64-bit to 32-bit truncation to worry >>> about... >> Having a problem building . >> >> CALL scripts/checksyscalls.sh >> :1307:2: warning: #warning syscall copy_file_range not implemen= ted >> [-Wcpp] >> CHK include/generated/compile.h >> CALL arch/powerpc/kernel/systbl_chk.sh >> CC mm/memory.o >> CHK kernel/config_data.h >> mm/memory.c: In function =C3=A2=E2=82=AC=CB=9Cinsert_pfn=C3=A2=E2=82=AC= =E2=84=A2: >> mm/memory.c:1520:9: error: implicit declaration of function >> =C3=A2=E2=82=AC=CB=9Cpfn_t_to_pfn=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Di= mplicit-function-declaration] >> pr_info("%s: entry: %#llx pfn: %#lx\n", __func__, >> ^ >> mm/memory.c:1520:9: warning: format =C3=A2=E2=82=AC=CB=9C%lx=C3=A2=E2=82= =AC=E2=84=A2 expects argument of type >> =C3=A2=E2=82=AC=CB=9Clong unsigned int=C3=A2=E2=82=AC=E2=84=A2, but ar= gument 4 has type =C3=A2=E2=82=AC=CB=9Cint=C3=A2=E2=82=AC=E2=84=A2 [-Wfor= mat=3D] > Yes, when you go to the preceding commit pfn_t_to_pfn() no longer > exists. You'll need to change the debug statement to: > > pr_info("%s: entry: %#llx pfn: %#lx\n", __func__, > (unsigned long long) entry, pfn); > > Thank you . Not getting any debug output . =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D /* Ok, finally just insert the thing.. */ entry =3D pte_mkspecial(pfn_pte(pfn, prot)); pr_info("%s: entry: %#llx pfn: %#lx\n", __func__, (unsigned long long) entry, pfn); set_pte_at(mm, addr, pte, entry); update_mmu_cache(vma, addr, pte); /* XXX: why not for insert_pag= e? */ =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D [ 15.622581] systemd[1]: Mounted POSIX Message Queue File System. [ 15.785050] systemd[1]: Mounting Configuration File System... [ 15.888907] systemd[1]: Starting Apply Kernel Variables... [ 15.994762] systemd[1]: Mounting FUSE Control File System... [ 16.153688] systemd[1]: Mounted FUSE Control File System. Ubuntu Xenial Xerus (development branch) Sam460ex ttyS0 Sam460ex login: --------------060108090406010106030807 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 1/28/2016 11:47 AM, Dan Williams wrote:
On Thu, Jan 28, 2016 at 2:41 AM, Julian Margetson <run=
away@candw.ms> wrote:

On 1/27/2016 3:34 PM, Dan Williams wrote:

On Wed, Jan 27, 2016 at 2:18 AM, Julian Margetson <runaway@candw.ms>
wrote:

On 1/26/2016 9:43 PM, Dan Williams wrote:
diff --git a/mm/memory.c b/mm/memory.c
index 30991f83d0bf..c44e387130b2 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1521,6 +1521,8 @@ static int insert_pfn(struct vm_area_struct
*vma, unsigned long addr,
                entry =3D pte_mkdevmap(pfn_t_pte(pfn, prot));
        else
                entry =3D pte_mkspecial(pfn_t_pte(pfn, prot));
+       pr_info("%s: entry: %#llx pfn: %#lx\n", __func__,
+                       (unsigned long long) entry, pfn_t_to_pfn(pfn));
        set_pte_at(mm, addr, pte, entry);
        update_mmu_cache(vma, addr, pte); /* XXX: why not for
insert_page? */

...of course for the passing case you'll need to drop the call to
pfn_t_to_pfn() and just print the pfn directly.

Thank you for the help tracking this down, it's much appreciated.

Happy to help out. Just need some guidance sometimes as I am relatively
new
at this.

No worries.

So, below is the failing case, what does insert_pfn print in the
passing case?  No need for the full log just the first few lines after
starting X when running the commit before this failing one... (commit
69660fd797c3 "x86, mm: introduce _PAGE_DEVMAP").

I'm still stumped given that PTE_RPN_SHIFT=3D=3DPAGE_SHIFT in this
configuration, so there's no 64-bit to 32-bit truncation to worry
about...

Having a problem building .

  CALL    scripts/checksyscalls.sh
<stdin>:1307:2: warning: #warning syscall copy_file_range not imple=
mented
[-Wcpp]
  CHK     include/generated/compile.h
  CALL    arch/powerpc/kernel/systbl_chk.sh
  CC      mm/memory.o
  CHK     kernel/config_data.h
mm/memory.c: In function =C3=A2=E2=82=AC=CB=9Cinsert_pfn=C3=A2=E2=82=AC=E2=
=84=A2:
mm/memory.c:1520:9: error: implicit declaration of function
=C3=A2=E2=82=AC=CB=9Cpfn_t_to_pfn=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Dimpl=
icit-function-declaration]
         pr_info("%s: entry: %#llx pfn: %#lx\n", __func__,
         ^
mm/memory.c:1520:9: warning: format =C3=A2=E2=82=AC=CB=9C%lx=C3=A2=E2=82=AC=
=E2=84=A2 expects argument of type
=C3=A2=E2=82=AC=CB=9Clong unsigned int=C3=A2=E2=82=AC=E2=84=A2, but argum=
ent 4 has type =C3=A2=E2=82=AC=CB=9Cint=C3=A2=E2=82=AC=E2=84=A2 [-Wformat=
=3D]

Yes, when you go to the preceding commit pfn_t_to_pfn() no longer
exists.  You'll need to change the debug statement to:

pr_info("%s: entry: %#llx pfn: %#lx\n", __func__,
                       (unsigned long long) entry, pfn);
Thank you .
Not getting any debug output .
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
        /* Ok, finally just insert the thing.. */
        entry =3D pte_mkspecial(pfn_pte(pfn, prot));
        pr_info("%s: entry: %#llx pfn: %#lx\n", __func__,
                      (unsigned long long) entry, pfn);
        set_pte_at(mm, addr, pte, entry);
        update_mmu_cache(vma, addr, pte); /* XXX: why not for insert_page=
? */

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

[   15.622581] systemd[1]: Mounted POSIX Message Queue File System.
[   15.785050] systemd[1]: Mounting Configuration File System...
[   15.888907] systemd[1]: Starting Apply Kernel Variables...
[   15.994762] systemd[1]: Mounting FUSE Control File System...
[   16.153688] systemd[1]: Mounted FUSE Control File System.

Ubuntu Xenial Xerus (development branch) Sam460ex ttyS0

Sam460ex login:



--------------060108090406010106030807-- --===============1513414553== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1513414553==--