From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPA90-00020n-ED for qemu-devel@nongnu.org; Fri, 29 Jan 2016 09:35:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPA8v-0006BE-Dt for qemu-devel@nongnu.org; Fri, 29 Jan 2016 09:35:26 -0500 References: <1454005340-15682-1-git-send-email-wei@redhat.com> From: Wei Huang Message-ID: <56AB78A6.7070505@redhat.com> Date: Fri, 29 Jan 2016 08:35:18 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: "qemu-trivial@nongnu.org" , "peter.maydell@linaro.org" , "qemu-devel@nongnu.org" , "zhaoshenglong@huawei.com" On 01/29/2016 04:10 AM, Shannon Zhao wrote: > Hi=EF=BC=8C >=20 > This makes ACPI work well but makes DT not work. The reason is systemd = or > acpid open /dev/input/event0 failed. So the interrupt could be injected= and > could see under /proc/interrupts but guest doesn't have any action. I'l= l > investigate why it opens failed later. That is interesting. Could you try it with the following? This reverses the order to down-up and worked on ACPI case. qemu_set_irq(qdev_get_gpio_in(pl061_dev, 3), 0); qemu_set_irq(qdev_get_gpio_in(pl061_dev, 3), 1); Thanks, -Wei >=20 > 2016=E5=B9=B41=E6=9C=8829=E6=97=A5=E6=98=9F=E6=9C=9F=E4=BA=94=EF=BC=8CW= ei Huang =E5=86=99=E9=81=93=EF=BC=9A >=20 >> When QEMU is hook'ed up with libvirt/virsh, the first ACPI reboot >> request will succeed; but the following shutdown/reboot requests >> fail to trigger VMs to react. Notice that in mach-virt machine >> model GPIO is defined as edge-triggered and active-high in ACPI. >> This patch changes the behavior of powerdown notifier from PULLUP >> to PULSE. It solves the problem described above (i.e. reboot >> continues to work). >> >> Signed-off-by: Wei Huang > >> --- >> hw/arm/virt.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c >> index 05f9087..b5468a9 100644 >> --- a/hw/arm/virt.c >> +++ b/hw/arm/virt.c >> @@ -546,7 +546,7 @@ static DeviceState *pl061_dev; >> static void virt_powerdown_req(Notifier *n, void *opaque) >> { >> /* use gpio Pin 3 for power button event */ >> - qemu_set_irq(qdev_get_gpio_in(pl061_dev, 3), 1); >> + qemu_irq_pulse(qdev_get_gpio_in(pl061_dev, 3)); >> } >> >> static Notifier virt_system_powerdown_notifier =3D { >> -- >> 1.8.3.1 >> >> >=20