From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756917AbcA3PWW (ORCPT ); Sat, 30 Jan 2016 10:22:22 -0500 Received: from smtp-out-251.synserver.de ([212.40.185.251]:1281 "EHLO smtp-out-189.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752820AbcA3PWV (ORCPT ); Sat, 30 Jan 2016 10:22:21 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 27418 Subject: Re: [PATCH 1/2] staging:iio:adc:added space around '-' To: Dan Carpenter , Jonathan Cameron , Joe Perches References: <115dd2e3f67706fd323c18b23871068ad36dfa94.1452878721.git.bhumirks@gmail.com> <56995378.1010204@metafoo.de> <20160120142137.GC6370@mwanda> <56A4FD7F.6010800@kernel.org> <56A5068D.4080207@metafoo.de> <56ACC4D2.8040802@kernel.org> <20160130151213.GC13219@mwanda> Cc: devel@driverdev.osuosl.org, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, Bhumika Goyal From: Lars-Peter Clausen Message-ID: <56ACD39A.1040003@metafoo.de> Date: Sat, 30 Jan 2016 16:15:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160130151213.GC13219@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2016 04:12 PM, Dan Carpenter wrote: > We could make checkpatch.pl not complain if the line says checkpatch: on > it. It would look like this. > > - in_voltage-voltage_thresh_low_value, > + in_voltage-voltage_thresh_low_value, /* checkpatch: not math */ > > I suppose I could have made the explanation longer since the it won't > complain about the 80 character limit... What do you guys think? We could add it as a temporary way to silence the checker. But it feels a bit ugly, there is really no reason why this shouldn't be a string, other than that the current device attr macros don't support that. - Lars