From: Kever Yang <kever.yang@rock-chips.com> To: Douglas Anderson <dianders@chromium.org>, John Youn <John.Youn@synopsys.com>, balbi@ti.com Cc: huangtao@rock-chips.com, stefan.wahren@i2se.com, heiko@sntech.de, johnyoun@synopsys.com, gregkh@linuxfoundation.org, ming.lei@canonical.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, yousaf.kaukab@intel.com, stern@rowland.harvard.edu, linux-rpi-kernel@lists.infradead.org, gregory.herrero@intel.com, william.wu@rock-chips.com, Julius Werner <jwerner@chromium.org>, dinguyen@opensource.altera.com Subject: Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time Date: Sun, 31 Jan 2016 17:36:00 +0800 [thread overview] Message-ID: <56ADD580.1070505@rock-chips.com> (raw) In-Reply-To: <1454034013-24657-19-git-send-email-dianders@chromium.org> Doug, On 01/29/2016 10:20 AM, Douglas Anderson wrote: > In dwc2_hcd_qh_deactivate() we will put some things on the > periodic_sched_ready list. These things won't be taken off the ready > list until the next SOF, which might be a little late. Let's put them > on right away. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > Tested-by: Heiko Stuebner <heiko@sntech.de> > Tested-by: Stefan Wahren <stefan.wahren@i2se.com> > --- > Changes in v6: > - Add Heiko's Tested-by. > - Add Stefan's Tested-by. > > Changes in v5: None > Changes in v4: > - Schedule periodic right away if it's time new for v4. > > Changes in v3: None > Changes in v2: None > > drivers/usb/dwc2/hcd_queue.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c > index 9b3c435339ee..3abb34a5fc5b 100644 > --- a/drivers/usb/dwc2/hcd_queue.c > +++ b/drivers/usb/dwc2/hcd_queue.c > @@ -1080,12 +1080,26 @@ void dwc2_hcd_qh_deactivate(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, > * Note: we purposely use the frame_number from the "hsotg" structure > * since we know SOF interrupt will handle future frames. > */ > - if (dwc2_frame_num_le(qh->next_active_frame, hsotg->frame_number)) > + if (dwc2_frame_num_le(qh->next_active_frame, hsotg->frame_number)) { > + enum dwc2_transaction_type tr_type; > + > + /* > + * We're bypassing the SOF handler which is normally what puts > + * us on the ready list because we're in a hurry and need to > + * try to catch up. > + */ > + dwc2_sch_vdbg(hsotg, "QH=%p IMM ready fn=%04x, nxt=%04x\n", > + qh, frame_number, qh->next_active_frame); > list_move_tail(&qh->qh_list_entry, > &hsotg->periodic_sched_ready); > - else > + > + tr_type = dwc2_hcd_select_transactions(hsotg); Do we need to add select_transactions call here? If we get into this function in interrupt and once we put the qh in ready queue, the qh can be handled in this frame again by the later function call of dwc_hcd_select_transactions, so what we need to to here is put it in ready list instead of inactive queue, and wait for the schedule. Thanks, - Kever > + if (tr_type != DWC2_TRANSACTION_NONE) > + dwc2_hcd_queue_transactions(hsotg, tr_type); > + } else { > list_move_tail(&qh->qh_list_entry, > &hsotg->periodic_sched_inactive); > + } > } > > /**
WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> To: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>, balbi-l0cyMroinI0@public.gmane.org Cc: huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org, stefan.wahren-eS4NqCHxEME@public.gmane.org, heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org, johnyoun-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, ming.lei-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, yousaf.kaukab-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Julius Werner <jwerner-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, william.wu-TNX95d0MmH7DzftRWevZcw@public.gmane.org, gregory.herrero-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, dinguyen-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org Subject: Re: [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time Date: Sun, 31 Jan 2016 17:36:00 +0800 [thread overview] Message-ID: <56ADD580.1070505@rock-chips.com> (raw) In-Reply-To: <1454034013-24657-19-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Doug, On 01/29/2016 10:20 AM, Douglas Anderson wrote: > In dwc2_hcd_qh_deactivate() we will put some things on the > periodic_sched_ready list. These things won't be taken off the ready > list until the next SOF, which might be a little late. Let's put them > on right away. > > Signed-off-by: Douglas Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> > Tested-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> > Tested-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org> > --- > Changes in v6: > - Add Heiko's Tested-by. > - Add Stefan's Tested-by. > > Changes in v5: None > Changes in v4: > - Schedule periodic right away if it's time new for v4. > > Changes in v3: None > Changes in v2: None > > drivers/usb/dwc2/hcd_queue.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc2/hcd_queue.c b/drivers/usb/dwc2/hcd_queue.c > index 9b3c435339ee..3abb34a5fc5b 100644 > --- a/drivers/usb/dwc2/hcd_queue.c > +++ b/drivers/usb/dwc2/hcd_queue.c > @@ -1080,12 +1080,26 @@ void dwc2_hcd_qh_deactivate(struct dwc2_hsotg *hsotg, struct dwc2_qh *qh, > * Note: we purposely use the frame_number from the "hsotg" structure > * since we know SOF interrupt will handle future frames. > */ > - if (dwc2_frame_num_le(qh->next_active_frame, hsotg->frame_number)) > + if (dwc2_frame_num_le(qh->next_active_frame, hsotg->frame_number)) { > + enum dwc2_transaction_type tr_type; > + > + /* > + * We're bypassing the SOF handler which is normally what puts > + * us on the ready list because we're in a hurry and need to > + * try to catch up. > + */ > + dwc2_sch_vdbg(hsotg, "QH=%p IMM ready fn=%04x, nxt=%04x\n", > + qh, frame_number, qh->next_active_frame); > list_move_tail(&qh->qh_list_entry, > &hsotg->periodic_sched_ready); > - else > + > + tr_type = dwc2_hcd_select_transactions(hsotg); Do we need to add select_transactions call here? If we get into this function in interrupt and once we put the qh in ready queue, the qh can be handled in this frame again by the later function call of dwc_hcd_select_transactions, so what we need to to here is put it in ready list instead of inactive queue, and wait for the schedule. Thanks, - Kever > + if (tr_type != DWC2_TRANSACTION_NONE) > + dwc2_hcd_queue_transactions(hsotg, tr_type); > + } else { > list_move_tail(&qh->qh_list_entry, > &hsotg->periodic_sched_inactive); > + } > } > > /**
next prev parent reply other threads:[~2016-01-31 9:36 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-29 2:19 [PATCH v6 0/22] usb: dwc2: host: Fix and speed up all the stuff, especially with splits Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 01/22] usb: dwc2: rockchip: Make the max_transfer_size automatic Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 02/22] usb: dwc2: host: Get aligned DMA in a more supported way Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 03/22] usb: dwc2: host: Set host_rx_fifo_size to 525 for rk3066 Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 04/22] usb: dwc2: host: Avoid use of chan->qh after qh freed Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 05/22] usb: dwc2: host: Always add to the tail of queues Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 06/22] usb: dwc2: host: fix split transfer schedule sequence Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 07/22] usb: dwc2: host: Add scheduler tracing Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:19 ` [PATCH v6 08/22] usb: dwc2: host: Add a delay before releasing periodic bandwidth Douglas Anderson 2016-01-29 2:19 ` Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 09/22] usb: dwc2: host: Giveback URB in tasklet context Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 10/22] usb: dwc2: host: Properly set the HFIR Douglas Anderson 2016-01-31 9:23 ` Kever Yang 2016-01-31 9:23 ` Kever Yang 2016-01-31 22:19 ` Doug Anderson 2016-02-10 2:08 ` John Youn 2016-01-29 2:20 ` [PATCH v6 11/22] usb: dwc2: host: There's not really a TT for the root hub Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-01-31 9:25 ` Kever Yang 2016-01-29 2:20 ` [PATCH v6 12/22] usb: dwc2: host: Use periodic interrupt even with DMA Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 13/22] usb: dwc2: host: Rename some fields in struct dwc2_qh Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 14/22] usb: dwc2: host: Reorder things in hcd_queue.c Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 15/22] usb: dwc2: host: Split code out to make dwc2_do_reserve() Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 16/22] usb: dwc2: host: Add scheduler logging for missed SOFs Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 17/22] usb: dwc2: host: Manage frame nums better in scheduler Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-02-03 20:29 ` Doug Anderson 2016-02-03 20:29 ` Doug Anderson 2016-02-09 9:53 ` Herrero, Gregory 2016-01-29 2:20 ` [PATCH v6 18/22] usb: dwc2: host: Schedule periodic right away if it's time Douglas Anderson 2016-01-31 9:36 ` Kever Yang [this message] 2016-01-31 9:36 ` Kever Yang 2016-01-31 22:09 ` Doug Anderson 2016-01-31 22:09 ` Doug Anderson 2016-02-01 3:32 ` Kever Yang 2016-02-01 4:36 ` Doug Anderson 2016-02-01 4:36 ` Doug Anderson 2016-02-02 0:36 ` Doug Anderson 2016-02-02 0:36 ` Doug Anderson 2016-02-02 7:04 ` Kever Yang 2016-02-02 7:04 ` Kever Yang 2016-02-02 23:28 ` Doug Anderson 2016-02-02 23:28 ` Doug Anderson 2016-01-29 2:20 ` [PATCH v6 19/22] usb: dwc2: host: Add dwc2_hcd_get_future_frame_number() call Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 20/22] usb: dwc2: host: Properly set even/odd frame Douglas Anderson 2016-02-02 7:46 ` Kever Yang 2016-02-02 22:47 ` Doug Anderson 2016-02-02 22:47 ` Doug Anderson 2016-02-03 7:47 ` Kever Yang 2016-02-03 7:47 ` Kever Yang 2016-01-29 2:20 ` [PATCH v6 21/22] usb: dwc2: host: Totally redo the microframe scheduler Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-01-29 2:20 ` [PATCH v6 22/22] usb: dwc2: host: If using uframe scheduler, end splits better Douglas Anderson 2016-01-29 2:20 ` Douglas Anderson 2016-02-02 23:57 ` [PATCH v6 0/22] usb: dwc2: host: Fix and speed up all the stuff, especially with splits John Youn 2016-02-02 23:57 ` John Youn 2016-02-03 18:23 ` Doug Anderson 2016-02-03 18:23 ` Doug Anderson 2016-02-10 2:25 ` John Youn 2016-02-10 2:25 ` John Youn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=56ADD580.1070505@rock-chips.com \ --to=kever.yang@rock-chips.com \ --cc=John.Youn@synopsys.com \ --cc=balbi@ti.com \ --cc=dianders@chromium.org \ --cc=dinguyen@opensource.altera.com \ --cc=gregkh@linuxfoundation.org \ --cc=gregory.herrero@intel.com \ --cc=heiko@sntech.de \ --cc=huangtao@rock-chips.com \ --cc=johnyoun@synopsys.com \ --cc=jwerner@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=ming.lei@canonical.com \ --cc=stefan.wahren@i2se.com \ --cc=stern@rowland.harvard.edu \ --cc=william.wu@rock-chips.com \ --cc=yousaf.kaukab@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.