From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQ8uP-0006Qi-3l for qemu-devel@nongnu.org; Mon, 01 Feb 2016 02:28:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQ8uL-0007rN-TM for qemu-devel@nongnu.org; Mon, 01 Feb 2016 02:28:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQ8uB-0007qL-8q for qemu-devel@nongnu.org; Mon, 01 Feb 2016 02:28:21 -0500 References: <1453883380-10532-1-git-send-email-zhang.zhanghailiang@huawei.com> <1453883380-10532-3-git-send-email-zhang.zhanghailiang@huawei.com> <56AECB89.1080901@redhat.com> <56AEF8EB.4070709@huawei.com> From: Jason Wang Message-ID: <56AF08F8.9030709@redhat.com> Date: Mon, 1 Feb 2016 15:27:52 +0800 MIME-Version: 1.0 In-Reply-To: <56AEF8EB.4070709@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hailiang Zhang , qemu-devel@nongnu.org Cc: Paolo Bonzini , peter.huangpeng@huawei.com, zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn On 02/01/2016 02:19 PM, Hailiang Zhang wrote: > On 2016/2/1 11:05, Jason Wang wrote: >> >> >> On 01/27/2016 04:29 PM, zhanghailiang wrote: >>> Make the helper object_create() public and fix its first >>> parameter to accept NULL value. >> >> Looks not very nice. Maybe pass a new predicate func for sanity check it >> better. >> > > OK, but here is it better to check if the predicate func is NULL ? > > Thanks, > Hailiang Not sure, but if you stick to check against NULL, need a separate patch.