From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752304AbcBAIkG (ORCPT ); Mon, 1 Feb 2016 03:40:06 -0500 Received: from mga03.intel.com ([134.134.136.65]:41825 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751587AbcBAIkE (ORCPT ); Mon, 1 Feb 2016 03:40:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,379,1449561600"; d="scan'208";a="893619661" Subject: Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs To: Gustavo Padovan , Greg Kroah-Hartman References: <1454102426-20637-1-git-send-email-gustavo@padovan.org> <1454102426-20637-10-git-send-email-gustavo@padovan.org> Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, Daniel Stone , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Riley Andrews , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , Gustavo Padovan From: Maarten Lankhorst Message-ID: <56AF19D5.5010505@linux.intel.com> Date: Mon, 1 Feb 2016 09:39:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1454102426-20637-10-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 29-01-16 om 22:20 schreef Gustavo Padovan: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > This only helps if you reject flags != 0 in the ioctl, else when you extend the abi userspace might initialize it with garbage. ~Maarten From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs Date: Mon, 1 Feb 2016 09:39:49 +0100 Message-ID: <56AF19D5.5010505@linux.intel.com> References: <1454102426-20637-1-git-send-email-gustavo@padovan.org> <1454102426-20637-10-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id EDE816E245 for ; Mon, 1 Feb 2016 00:40:04 -0800 (PST) In-Reply-To: <1454102426-20637-10-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Greg Kroah-Hartman Cc: devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Gustavo Padovan , John Harrison List-Id: dri-devel@lists.freedesktop.org T3AgMjktMDEtMTYgb20gMjI6MjAgc2NocmVlZiBHdXN0YXZvIFBhZG92YW46Cj4gRnJvbTogR3Vz dGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgo+Cj4gUGxheSBz YWZlIGFuZCBhZGQgZmxhZ3MgbWVtYmVyIHRvIGFsbCBzdHJ1Y3RzLiBTbyB3ZSBkb24ndCBuZWVk IHRvCj4gYnJlYWsgQVBJIG9yIGNyZWF0ZSBuZXcgSU9DVEwgaW4gdGhlIGZ1dHVyZSBpZiBuZXcg ZmVhdHVyZXMgdGhhdCByZXF1aXJlcwo+IGZsYWdzIGFyaXNlcy4KPgpUaGlzIG9ubHkgaGVscHMg aWYgeW91IHJlamVjdCBmbGFncyAhPSAwIGluIHRoZSBpb2N0bCwgZWxzZSB3aGVuIHlvdSBleHRl bmQgdGhlIGFiaSB1c2Vyc3BhY2UgbWlnaHQgaW5pdGlhbGl6ZSBpdCB3aXRoIGdhcmJhZ2UuCgp+ TWFhcnRlbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=