From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support Date: Mon, 1 Feb 2016 13:09:15 +0100 Message-ID: <56AF4AEB.40109@st.com> References: <1452773795-24216-1-git-send-email-mcoquelin.stm32@gmail.com> <1452773795-24216-5-git-send-email-mcoquelin.stm32@gmail.com> <2151471.Wut3mQ9SS7@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mx07-00178001.pphosted.com ([62.209.51.94]:25478 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753671AbcBAMJy (ORCPT ); Mon, 1 Feb 2016 07:09:54 -0500 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Maxime Coquelin , Arnd Bergmann , Linus Walleij Cc: Mark Rutland , "devicetree@vger.kernel.org" , Daniel Thompson , Bruno Herrera , Patrice CHOTARD , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Rob Herring , =?UTF-8?Q?Andreas_F=c3=a4rber?= , "linux-arm-kernel@lists.infradead.org" On 02/01/2016 11:39 AM, Maxime Coquelin wrote: > 2016-02-01 11:21 GMT+01:00 Arnd Bergmann : >> On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote: >>> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin >>> wrote: >>> >>>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32 >>>> family of MCUs. >>>> >>>> While it only supports STM32F429 for now, it has been designed to enable >>>> support of other MCUs of the family (e.g. STM32F746). >>>> >>>> Acked-by: Patrice Chotard >>>> Signed-off-by: Maxime Coquelin >>> This patch applied for kernel v4.6. >>> >> This breaks the kernel build, please revert: >> >> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory > Right, I missed to notify this dependency to Linus, sorry about that. > This dependency is no more needed, so I could just move the macros to > the driver side. > > Note that I also noticed a breakage at build time due to field > renaming in gpio_chip structure (dev -> parent). > > I propose to rebase the series and move the defines into the driver. > Is it ok for you? > I have rebased the series, taking care to fix the mentioned problems. Linus, do you confirm you will revert STM32 pinctrl patches from your tree? Thanks, Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.coquelin@st.com (Maxime Coquelin) Date: Mon, 1 Feb 2016 13:09:15 +0100 Subject: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support In-Reply-To: References: <1452773795-24216-1-git-send-email-mcoquelin.stm32@gmail.com> <1452773795-24216-5-git-send-email-mcoquelin.stm32@gmail.com> <2151471.Wut3mQ9SS7@wuerfel> Message-ID: <56AF4AEB.40109@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/01/2016 11:39 AM, Maxime Coquelin wrote: > 2016-02-01 11:21 GMT+01:00 Arnd Bergmann : >> On Wednesday 27 January 2016 14:16:32 Linus Walleij wrote: >>> On Thu, Jan 14, 2016 at 1:16 PM, Maxime Coquelin >>> wrote: >>> >>>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32 >>>> family of MCUs. >>>> >>>> While it only supports STM32F429 for now, it has been designed to enable >>>> support of other MCUs of the family (e.g. STM32F746). >>>> >>>> Acked-by: Patrice Chotard >>>> Signed-off-by: Maxime Coquelin >>> This patch applied for kernel v4.6. >>> >> This breaks the kernel build, please revert: >> >> drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No such file or directory > Right, I missed to notify this dependency to Linus, sorry about that. > This dependency is no more needed, so I could just move the macros to > the driver side. > > Note that I also noticed a breakage at build time due to field > renaming in gpio_chip structure (dev -> parent). > > I propose to rebase the series and move the defines into the driver. > Is it ok for you? > I have rebased the series, taking care to fix the mentioned problems. Linus, do you confirm you will revert STM32 pinctrl patches from your tree? Thanks, Maxime