From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH] drm/i915/execlists: Move WA_TAIL_DWORDS to callee Date: Mon, 1 Feb 2016 14:00:43 +0000 Message-ID: <56AF650B.7030105@intel.com> References: <56A8B7A4.3090404@intel.com> <1453913874-23076-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 08C106E43D for ; Mon, 1 Feb 2016 06:01:20 -0800 (PST) In-Reply-To: <1453913874-23076-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gMjcvMDEvMTYgMTY6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBDdXJyZW50bHkgZW1pdC1y ZXF1ZXN0IHN0YXJ0cyB3cml0aW5nIHRvIHRoZSByaW5nIGFuZCByZXNlcnZlcyBzcGFjZSBmb3IK PiBhIHdvcmthcm91bmQgdG8gYmUgZW1pdHRlZCBsYXRlciB3aGlsc3Qgc3VibWl0dGluZyB0aGUg cmVxdWVzdC4gSXQgaXMKPiBlYXNpZXIgdG8gcmVhZCBpZiB0aGUgY2FsbGVyIG9ubHkgYWxsb2Nh dGVzIHN1ZmZpY2llbnQgc3BhY2UgZm9yIGl0cwo+IGFjY2VzcyAodGhlbiB0aGUgcmVhZGVyIGNh biBxdWlja2x5IHZlcmlmeSB0aGF0IHRoZSByaW5nIGJlZ2luIGFsbG9jYXRlcwo+IHRoZSBleGFj dCBzcGFjZSBmb3IgdGhlIG51bWJlciBvZiBkd29yZHMgZW1pdHRlZCkgYW5kIGNsb3NlcyB0aGUg YWNjZXNzCj4gdG8gdGhlIHJpbmcuIER1cmluZyBzdWJtaXQsIGlmIHdlIG5lZWQgdG8gYWRkIHRo ZSB3b3JrYXJvdW5kLCB3ZSBjYW4KPiByZWFjcXVpcmUgcmluZyBhY2Nlc3MsIGluIHRoZSBhc3N1 cmFuY2UgdGhhdCB3ZSByZXNlcnZlZCBzcGFjZSBmb3IKPiBvdXJzZWx2ZXMgd2hlbiBiZWdpbm5p bmcgdGhlIHJlcXVlc3QuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiBDYzogRGF2ZSBHb3Jkb24gPGRhdmlkLnMuZ29yZG9uQGludGVs LmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAZ21haWwuY29tPgo+IC0tLQoK R2VuZXJhbGx5LCB5ZXMsIGJ1dCAuLi4KCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYyB8IDQxICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIDEg ZmlsZSBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggZGE5N2JjNTY2NmI1Li43NGZjZjBmOGQ5N2EgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC03NjAsMjMgKzc2MCwyNyBAQCBzdGF0 aWMgaW50IGxvZ2ljYWxfcmluZ193YWl0X2Zvcl9zcGFjZShzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3Jl cXVlc3QgKnJlcSwKPiAgICAqIHBvaW50LCB0aGUgdGFpbCAqaW5zaWRlKiB0aGUgY29udGV4dCBp cyB1cGRhdGVkIGFuZCB0aGUgRUxTUCB3cml0dGVuIHRvLgo+ICAgICovCj4gICBzdGF0aWMgaW50 Cj4gLWludGVsX2xvZ2ljYWxfcmluZ19hZHZhbmNlX2FuZF9zdWJtaXQoc3RydWN0IGRybV9pOTE1 X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICtpbnRlbF9sb2dpY2FsX3Jpbmdfc3VibWl0KHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKClRoZSBjb21tZW50IGFib3ZlIHRoaXMg ZnVuY3Rpb24gc3RpbGwgaGFzIHRoZSBvbGQgbmFtZQoKPiAgIHsKPiAgIAlzdHJ1Y3QgaW50ZWxf cmluZ2J1ZmZlciAqcmluZ2J1ZiA9IHJlcXVlc3QtPnJpbmdidWY7Cj4gICAJc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gcmVxdWVzdC0+aTkxNTsKPgo+IC0JaW50ZWxfbG9naWNh bF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gICAJcmVxdWVzdC0+dGFpbCA9IHJpbmdidWYtPnRh aWw7Cj4KPiAgIAkvKgo+IC0JICogSGVyZSB3ZSBhZGQgdHdvIGV4dHJhIE5PT1BzIGFzIHBhZGRp bmcgdG8gYXZvaWQKPiAtCSAqIGxpdGUgcmVzdG9yZSBvZiBhIGNvbnRleHQgd2l0aCBIRUFEPT1U QUlMLgo+IC0JICoKPiAtCSAqIENhbGxlciBtdXN0IHJlc2VydmUgV0FfVEFJTF9EV09SRFMgZm9y IHVzIQo+ICsJICogUmVzZXJ2ZSBzcGFjZSBmb3IgMiBOT09QcyBhdCB0aGUgZW5kIG9mIGVhY2gg cmVxdWVzdCB0byBiZQo+ICsJICogdXNlZCBhcyBhIHdvcmthcm91bmQgZm9yIG5vdCBiZWluZyBh bGxvd2VkIHRvIGRvIGxpdGUKPiArCSAqIHJlc3RvcmUgd2l0aCBIRUFEPT1UQUlMIChXYUlkbGVM aXRlUmVzdG9yZSkuCj4gICAJICovCj4gLQlpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5nYnVm LCBNSV9OT09QKTsKPiAtCWludGVsX2xvZ2ljYWxfcmluZ19lbWl0KHJpbmdidWYsIE1JX05PT1Ap Owo+IC0JaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gKwlpZiAoMSAvKiBu ZWVkIFdhSWRsZUxpdGVSZXN0b3JlICovKSB7Cj4gKwkJaW50IHJldCA9IGludGVsX2xvZ2ljYWxf cmluZ19iZWdpbihyZXF1ZXN0LCAyKTsKPiArCQlpZiAocmV0KQo+ICsJCQlyZXR1cm4gcmV0Owo+ ICsKPiArCQlpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5nYnVmLCBNSV9OT09QKTsKPiArCQlp bnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5nYnVmLCBNSV9OT09QKTsKPiArCQlpbnRlbF9sb2dp Y2FsX3JpbmdfYWR2YW5jZShyaW5nYnVmKTsKPiArCX0KCkhvdyBhYm91dCBrZWVwaW5nIHRoZSBn ZW5lcmFsaXNhdGlvbiBvZiBlbWl0dGluZyBXQV9UQUlMX0RXT1JEUyBvZiBOT09QcyAKKGFuZCB0 aGUgdGVzdCBjYW4gYmUgaWYgdGhpcyBpcyBncmVhdGVyIHRoYW4gMCkgLi4uCgo+Cj4gICAJaWYg KGludGVsX3Jpbmdfc3RvcHBlZChyZXF1ZXN0LT5yaW5nKSkKPiAgIAkJcmV0dXJuIDA7Cj4gQEAg LTE4NTgsMTMgKzE4NjIsNiBAQCBzdGF0aWMgdm9pZCBieHRfYV9zZXRfc2Vxbm8oc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqcmluZywgdTMyIHNlcW5vKQo+ICAgCWludGVsX2ZsdXNoX3N0YXR1c19w YWdlKHJpbmcsIEk5MTVfR0VNX0hXU19JTkRFWCk7Cj4gICB9Cj4KPiAtLyoKPiAtICogUmVzZXJ2 ZSBzcGFjZSBmb3IgMiBOT09QcyBhdCB0aGUgZW5kIG9mIGVhY2ggcmVxdWVzdCB0byBiZQo+IC0g KiB1c2VkIGFzIGEgd29ya2Fyb3VuZCBmb3Igbm90IGJlaW5nIGFsbG93ZWQgdG8gZG8gbGl0ZQo+ IC0gKiByZXN0b3JlIHdpdGggSEVBRD09VEFJTCAoV2FJZGxlTGl0ZVJlc3RvcmUpLgo+IC0gKi8K PiAtI2RlZmluZSBXQV9UQUlMX0RXT1JEUyAyCj4gLQoKLi4uIGFuZCBrZWVwaW5nIHRoZSBkZWZp bmUgb2YgV0FfVEFJTF9EV09SRFMgKGJ1dCBwcmVmZXJhYmx5IG1vdmVkIHRvIAp0aGUgdG9wIG9m IHRoZSBmaWxlKSwgYW5kIGNoYW5naW5nIGludGVsX2xvZ2ljYWxfcmluZ19yZXNlcnZlX3NwYWNl KCkgdG8gCmFkZCB0aGlzIG1hbnkgZHdvcmRzIHRvIHRoZSBzcGFjZSByZXNlcnZlZC4KClRoYXQg c2hvdWxkIG1ha2UgY2xlYXIgdGhlIGNvbm5lY3Rpb24gYmV0d2VlbjoKMS4gcmVzZXJ2aW5nIHRo ZSBzcGFjZSAoaW50ZWxfbG9naWNhbF9yaW5nX3Jlc2VydmVfc3BhY2UpCjIuIGZpbGxpbmcgaXQg d2l0aCBOT09QcyAoaW50ZWxfbG9naWNhbF9yaW5nX3N1Ym1pdCkKMy4gdXNpbmcgdGhlIHNwYWNl IChleGVjbGlzdHNfY29udGV4dF91bnF1ZXVlKQoKYmVjYXVzZSB0aGV5IHdvdWxkIGVhY2ggbWVu dGlvbiBXQV9UQUlMX0RXT1JEUyBhbmQgV2FJZGxlTGl0ZVJlc3RvcmUsIAphbmQgaXQgd2lsbCBi ZSBvYnZpb3VzIHRoYXQgaXQgcmVhbGx5IGlzIGp1c3QgYSBmaXggZm9yIGEgc3BlY2lmaWMgaXNz dWUgCndpdGggZXhlY2xpc3Qgc3VibWlzc2lvbi4KCkJUVyB0aGUgY29tbWVudCBpbiBleGVjbGlz dHNfY29udGV4dF91bnF1ZXVlKCkgaXMgKG9yIHdpbGwgYmUpIHdyb25nIAphYm91dCB3aGVyZSB0 aGUgcGFkZGluZyBpcyBhZGRlZC4KCkFsbCB0aGUgcmVtYWluaW5nIGNoYW5nZXMgYmVsb3cgbG9v ayBnb29kIDopCgouRGF2ZS4KCj4gICBzdGF0aWMgaW5saW5lIHUzMiBod3Nfc2Vxbm9fYWRkcmVz cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICB7Cj4gICAJcmV0dXJuIGVuZ2lu ZS0+c3RhdHVzX3BhZ2UuZ2Z4X2FkZHIgKyBJOTE1X0dFTV9IV1NfSU5ERVhfQUREUjsKPiBAQCAt MTg3NSw3ICsxODcyLDcgQEAgc3RhdGljIGludCBnZW44X2VtaXRfcmVxdWVzdChzdHJ1Y3QgZHJt X2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gICAJc3RydWN0IGludGVsX3JpbmdidWZmZXIg KnJpbmdidWYgPSByZXF1ZXN0LT5yaW5nYnVmOwo+ICAgCWludCByZXQ7Cj4KPiAtCXJldCA9IGlu dGVsX2xvZ2ljYWxfcmluZ19iZWdpbihyZXF1ZXN0LCA2ICsgV0FfVEFJTF9EV09SRFMpOwo+ICsJ cmV0ID0gaW50ZWxfbG9naWNhbF9yaW5nX2JlZ2luKHJlcXVlc3QsIDYpOwo+ICAgCWlmIChyZXQp Cj4gICAJCXJldHVybiByZXQ7Cj4KPiBAQCAtMTg5MSw3ICsxODg4LDkgQEAgc3RhdGljIGludCBn ZW44X2VtaXRfcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4g ICAJaW50ZWxfbG9naWNhbF9yaW5nX2VtaXQocmluZ2J1ZiwgaTkxNV9nZW1fcmVxdWVzdF9nZXRf c2Vxbm8ocmVxdWVzdCkpOwo+ICAgCWludGVsX2xvZ2ljYWxfcmluZ19lbWl0KHJpbmdidWYsIE1J X1VTRVJfSU5URVJSVVBUKTsKPiAgIAlpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5nYnVmLCBN SV9OT09QKTsKPiAtCXJldHVybiBpbnRlbF9sb2dpY2FsX3JpbmdfYWR2YW5jZV9hbmRfc3VibWl0 KHJlcXVlc3QpOwo+ICsJaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFuY2UocmluZ2J1Zik7Cj4gKwo+ ICsJcmV0dXJuIGludGVsX2xvZ2ljYWxfcmluZ19zdWJtaXQocmVxdWVzdCk7Cj4gICB9Cj4KPiAg IHN0YXRpYyBpbnQgZ2VuOF9lbWl0X3JlcXVlc3RfcmVuZGVyKHN0cnVjdCBkcm1faTkxNV9nZW1f cmVxdWVzdCAqcmVxdWVzdCkKPiBAQCAtMTg5OSw3ICsxODk4LDcgQEAgc3RhdGljIGludCBnZW44 X2VtaXRfcmVxdWVzdF9yZW5kZXIoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0 KQo+ICAgCXN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmID0gcmVxdWVzdC0+cmluZ2J1 ZjsKPiAgIAlpbnQgcmV0Owo+Cj4gLQlyZXQgPSBpbnRlbF9sb2dpY2FsX3JpbmdfYmVnaW4ocmVx dWVzdCwgNiArIFdBX1RBSUxfRFdPUkRTKTsKPiArCXJldCA9IGludGVsX2xvZ2ljYWxfcmluZ19i ZWdpbihyZXF1ZXN0LCA2KTsKPiAgIAlpZiAocmV0KQo+ICAgCQlyZXR1cm4gcmV0Owo+Cj4gQEAg LTE5MTYsNyArMTkxNSw5IEBAIHN0YXRpYyBpbnQgZ2VuOF9lbWl0X3JlcXVlc3RfcmVuZGVyKHN0 cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCkKPiAgIAlpbnRlbF9sb2dpY2FsX3Jp bmdfZW1pdChyaW5nYnVmLCAwKTsKPiAgIAlpbnRlbF9sb2dpY2FsX3JpbmdfZW1pdChyaW5nYnVm LCBpOTE1X2dlbV9yZXF1ZXN0X2dldF9zZXFubyhyZXF1ZXN0KSk7Cj4gICAJaW50ZWxfbG9naWNh bF9yaW5nX2VtaXQocmluZ2J1ZiwgTUlfVVNFUl9JTlRFUlJVUFQpOwo+IC0JcmV0dXJuIGludGVs X2xvZ2ljYWxfcmluZ19hZHZhbmNlX2FuZF9zdWJtaXQocmVxdWVzdCk7Cj4gKwlpbnRlbF9sb2dp Y2FsX3JpbmdfYWR2YW5jZShyaW5nYnVmKTsKPiArCj4gKwlyZXR1cm4gaW50ZWxfbG9naWNhbF9y aW5nX3N1Ym1pdChyZXF1ZXN0KTsKPiAgIH0KPgo+ICAgc3RhdGljIGludCBpbnRlbF9scl9jb250 ZXh0X3JlbmRlcl9zdGF0ZV9pbml0KHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxKQo+ CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=