From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from goalie.tycho.ncsc.mil (goalie [144.51.242.250]) by tarius.tycho.ncsc.mil (8.14.4/8.14.4) with ESMTP id u11EEkkn008075 for ; Mon, 1 Feb 2016 09:14:46 -0500 Subject: Re: [PATCH 1/3] libsepol: cil: always initialize __cil_permx_to_sepol_class_perms() result To: Nicolas Iooss , References: <1454236598-1829-1-git-send-email-nicolas.iooss@m4x.org> From: Steve Lawrence Message-ID: <56AF6854.50200@tresys.com> Date: Mon, 1 Feb 2016 09:14:44 -0500 MIME-Version: 1.0 In-Reply-To: <1454236598-1829-1-git-send-email-nicolas.iooss@m4x.org> Content-Type: text/plain; charset="windows-1252" List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On 01/31/2016 05:36 AM, Nicolas Iooss wrote: > clang warns that __cil_permx_to_sepol_class_perms() return value, rc, > may be unitialized: > > ../cil/src/cil_binary.c:4188:9: error: variable 'rc' may be > uninitialized when used here [-Werror,-Wconditional-uninitialized] > return rc; > ^~ > ../cil/src/cil_binary.c:4148:8: note: initialize the variable 'rc' > to silence this warning > int rc; > ^ > = 0 > > This theoretically happens when cil_expand_class(permx->obj) returns an > empty list. > > Signed-off-by: Nicolas Iooss All patches applied. Thanks! - Steve > --- > libsepol/cil/src/cil_binary.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libsepol/cil/src/cil_binary.c b/libsepol/cil/src/cil_binary.c > index 433f92e40a8e..47c751c0ef06 100644 > --- a/libsepol/cil/src/cil_binary.c > +++ b/libsepol/cil/src/cil_binary.c > @@ -4145,7 +4145,7 @@ exit: > > static int __cil_permx_to_sepol_class_perms(policydb_t *pdb, struct cil_permissionx *permx, class_perm_node_t **sepol_class_perms) > { > - int rc; > + int rc = SEPOL_OK; > struct cil_list *class_list = NULL; > struct cil_list_item *c; > class_datum_t *sepol_obj = NULL; >