From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753563AbcBATWo (ORCPT ); Mon, 1 Feb 2016 14:22:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49915 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753501AbcBATWn (ORCPT ); Mon, 1 Feb 2016 14:22:43 -0500 Subject: Re: [PATCH 3/4] time,acct: drop irq save & restore from __acct_update_integrals To: Peter Zijlstra References: <1454292751-23472-1-git-send-email-riel@redhat.com> <1454292751-23472-4-git-send-email-riel@redhat.com> <20160201092856.GM6357@twins.programming.kicks-ass.net> Cc: linux-kernel@vger.kernel.org, fweisbec@gmail.com, tglx@linutronix.de, mingo@kernel.org, luto@amacapital.net, clark@redhat.com From: Rik van Riel Message-ID: <56AFB080.7020509@redhat.com> Date: Mon, 1 Feb 2016 14:22:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160201092856.GM6357@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2016 04:28 AM, Peter Zijlstra wrote: > Its just the acct_account_cputime() callers that I suspect will all have > IRQs disabled, but it would still be goot to verify that with a > WARN_ON(!irqs_disabled()) test in there for at least one test run, and > then include that you did this in the Changelog. I verified that the WARN_ON did not trigger, but I forgot to include that in the changelog for v4 -- All rights reversed