From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQRNW-0004kF-IQ for qemu-devel@nongnu.org; Mon, 01 Feb 2016 22:11:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQRNS-00075V-46 for qemu-devel@nongnu.org; Mon, 01 Feb 2016 22:11:42 -0500 Received: from m199-177.yeah.net ([123.58.177.199]:53338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQRNR-000747-I3 for qemu-devel@nongnu.org; Mon, 01 Feb 2016 22:11:38 -0500 References: <1454328077-18820-1-git-send-email-zhang.zhanghailiang@huawei.com> From: Yang Hongyang Message-ID: <56B01E53.6060306@easystack.cn> Date: Tue, 2 Feb 2016 11:11:15 +0800 MIME-Version: 1.0 In-Reply-To: <1454328077-18820-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] Netfilter: Add each netdev a default filter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: jasowang@redhat.com, dgilbert@redhat.com, zhangchen.fnst@cn.fujitsu.com If we have to add a default filter, then I have a suggestion only for this series: 1. Add a nop filter. filter-nop.c 2. Add a "default-filter=xxx" property to -netdev, if not specified, default to nop. On 02/01/2016 08:01 PM, zhanghailiang wrote: > This series is a prerequisite for COLO, here we add each netdev > a default buffer filter, it is disabled by default, and has > no side effect for delivering packets in net layer. > > Note: this series is based on patch > '[PATCH v2] net/filter: Fix the output information for command 'info network' > > v3: > - Drop patch '[PATCH RFC v2 2/5] vl: Make object_create() public' > - Use object_new_with_props() instead of object_create() (Daniel) > v2: > - Drop the patch net/filter: prevent the default filter to be deleted' (Jason) > - Re-implement netdev_add_filter() by re-using object_object() (Jason) > - Send patch 'net/filter: Fix the output information for command 'info > network' as an independent one. (Jason) > > zhanghailiang (4): > net/filter: Add a 'status' property for filter object > net/filter: Introduce a helper to add a filter to the netdev > filter-buffer: Accept zero interval > net/filter: Add a default filter to each netdev > > include/net/filter.h | 12 ++++++++ > net/filter-buffer.c | 10 ------- > net/filter.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++++++++ > net/net.c | 23 +++++++++++++++ > 4 files changed, 114 insertions(+), 10 deletions(-) > -- Thanks, Yang