All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Ingo Molnar" <mingo@kernel.org>
Cc: "Peter Zijlstra" <a.p.zijlstra@chello.nl>, <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [PATCH v2] x86/mm: avoid premature success when changing page attributes
Date: Tue, 02 Feb 2016 01:46:17 -0700	[thread overview]
Message-ID: <56B07AE902000078000CD54A@prv-mh.provo.novell.com> (raw)
In-Reply-To: <20160128084232.GA24464@gmail.com>

>>> On 28.01.16 at 09:42, <mingo@kernel.org> wrote:
> Could we try a v3?

Okay, I withdraw the patch: Upon further consideration it is note
really clear what the intended behavior of set_memory_*() on
address ranges with mapping holes is supposed to be. The original
issue was with set_memory_nx() (called from mark_rodata_ro())
stumbling across an unmapped region (resulting from an out of
tree change completely unmapping the kernel mappings of
address ranges passed to free_init_pages()). I simply don't have
the time to check whether the unmapping done with
CONFIG_DEBUG_PAGEALLOC would have a similar effect. The
net result in any event were pages (past the hole) reported as
problematic when CONFIG_DEBUG_WX is enabled.

Jan

  reply	other threads:[~2016-02-02  8:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 16:54 [PATCH] x86/mm: avoid premature success when changing page attributes Jan Beulich
2016-01-27 10:05 ` Thomas Gleixner
2016-01-27 10:44   ` Jan Beulich
2016-01-27 10:53     ` Thomas Gleixner
2016-01-27 11:10       ` Jan Beulich
2016-01-27 11:21       ` [PATCH v2] " Jan Beulich
2016-01-28  8:42         ` Ingo Molnar
2016-02-02  8:46           ` Jan Beulich [this message]
2016-02-09 14:30             ` Ingo Molnar
2016-02-10  9:03               ` [PATCH v3] " Jan Beulich
2016-02-25  9:45                 ` [tip:x86/mm] x86/mm: Avoid " tip-bot for Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B07AE902000078000CD54A@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.