From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQl6Q-0006hN-Dq for qemu-devel@nongnu.org; Tue, 02 Feb 2016 19:15:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQl6P-0007C9-E8 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 19:15:22 -0500 References: <1454417864-18774-1-git-send-email-berrange@redhat.com> <1454417864-18774-2-git-send-email-berrange@redhat.com> <56B13DF4.5010006@redhat.com> <56B13E92.3030709@suse.de> From: Eric Blake Message-ID: <56B14692.3050308@redhat.com> Date: Tue, 2 Feb 2016 17:15:14 -0700 MIME-Version: 1.0 In-Reply-To: <56B13E92.3030709@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9Wj7uHGvqC2oWq9nReF1k7sqP0q9DPeqE" Subject: Re: [Qemu-devel] [PATCH v5 01/10] qom: add helpers for UserCreatable object types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Wj7uHGvqC2oWq9nReF1k7sqP0q9DPeqE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/02/2016 04:41 PM, Andreas F=C3=A4rber wrote: > Am 03.02.2016 um 00:38 schrieb Eric Blake: >> On 02/02/2016 05:57 AM, Daniel P. Berrange wrote: >>> The QMP monitor code has two helper methods object_add >>> and qmp_object_del that are called from several places >>> in the code (QMP, HMP and main emulator startup). >>> >>> The HMP and main emulator startup code also share >>> further logic that extracts the qom-type & id >>> values from a qdict. >>> >>> We soon need to use this logic from qemu-img, qemu-io >>> and qemu-nbd too, but don't want those to depend on >>> the monitor, nor do we want to duplicate the code. >> >> Yay - merge conflicts with my work pending on Markus' qapi-next branch= : >> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg00254.html >=20 > Did I review the wrong patch then? I assumed this was the one I was > asked to look at just before FOSDEM... No, you got the right patch; it's just that I've been independently improving the code in hmp.c and vl.c that Dan is now refactoring, so at least one of us will have to rebase. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9Wj7uHGvqC2oWq9nReF1k7sqP0q9DPeqE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWsUaSAAoJEKeha0olJ0Nq48cH/0BErqHnyX0HxFn828oK0hwv a2Q+aGlYQe5XuuVP3OgYQbsAkUuFZ8s6MCUyrFXvqRqtkT5dadwvD+KqUKKuWmE/ w4R2hPlQz1wCYXsABlxZ2R0uKPVsYgIAIy2+fpnAaqJG+81af2xYvmjn9Wk2dNUg sbZD0V8HMPigsX4RS1u6Id+BzUgW49+Gvc6WEoNGu8P37N8L1G6pi9YpdYbU0VuJ VwgSEggAysWzzy7e3cNlGrb5ZZexZ7ojPIGXhzyp96qXfsDCNjcgUESWEsRBIzeQ 0B+A8ScKrsVyvER4QmgMMqdi1bh5znigs9aSb4Op3Jf5FjnWaa/jvN8HgxLlQ6Q= =gqD/ -----END PGP SIGNATURE----- --9Wj7uHGvqC2oWq9nReF1k7sqP0q9DPeqE--