From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQpQl-00083z-DI for qemu-devel@nongnu.org; Tue, 02 Feb 2016 23:52:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQpQi-0005e2-8O for qemu-devel@nongnu.org; Tue, 02 Feb 2016 23:52:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQpQi-0005dy-2o for qemu-devel@nongnu.org; Tue, 02 Feb 2016 23:52:36 -0500 References: <1454380581-7881-1-git-send-email-jasowang@redhat.com> From: Jason Wang Message-ID: <56B18788.9050807@redhat.com> Date: Wed, 3 Feb 2016 12:52:24 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/17] Net patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , maethor@subiron.org, samuel.thibault@ens-lyon.org Cc: Thomas Huth , QEMU Developers On 02/02/2016 07:05 PM, Peter Maydell wrote: > On 2 February 2016 at 02:36, Jason Wang wrote: >> The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a= 32ca4: >> >> hw: Clean up includes (2016-01-29 15:07:25 +0000) >> >> are available in the git repository at: >> >> https://github.com/jasowang/qemu.git tags/net-pull-request >> >> for you to fetch changes up to e8a7a1a574ed6728422959c8aa79ca584cdd1d4= d: >> >> net/filter: Fix the output information for command 'info network' (2= 016-02-02 10:21:28 +0800) >> >> ---------------------------------------------------------------- >> >> Major changes for net: >> >> - preparation for ipv6 support in slirp >> - fix tx infinite loops of e1000 >> - fix cadence_gem buffer overflow >> - rx netfilter were gone in reverse for future complex netfilter setup= s > Hi. I'm afraid this failed to build on w32: > > In file included from /home/petmay01/linaro/qemu-for-merges/slirp/slirp= .h:146, > from /home/petmay01/linaro/qemu-for-merges/stubs/slirp= .c:2: > /home/petmay01/linaro/qemu-for-merges/slirp/udp.h:79: error: expected > declaration specifiers or =E2=80=98...=E2=80=99 before =E2=80=98sa_fami= ly_t=E2=80=99 > In file included from /home/petmay01/linaro/qemu-for-merges/stubs/slirp= .c:2: > /home/petmay01/linaro/qemu-for-merges/slirp/slirp.h:330: error: > expected declaration specifiers or =E2=80=98...=E2=80=99 before =E2=80=98= sa_family_t=E2=80=99 > > thanks > -- PMM Oops, very sorry for the build failure. I've setup a cross build environment to test win32 build before each pull request in the future. For this issue, looks like there's no sa_family_t for windows. Possible solutions are: - switch to use unsigned short - or typedef sa_family_t as unsigned short for windows Samuel and Guillaume, thoughts for this? Thanks