From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ivan Boule <ivan.boule@6wind.com>
Subject: Re: [PATCH v2 9/9] pci: implement automatic bind/unbind
Date: Wed, 3 Feb 2016 10:26:26 +0100
Message-ID: <56B1C7C2.6070402@6wind.com>
References: <1453476464-31767-1-git-send-email-david.marchand@6wind.com>
 <1454078953-23744-1-git-send-email-david.marchand@6wind.com>
 <1454078953-23744-10-git-send-email-david.marchand@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: viktorin@rehivetech.com
To: David Marchand <david.marchand@6wind.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 47C8C2E81
 for <dev@dpdk.org>; Wed,  3 Feb 2016 10:26:42 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id p63so155460548wmp.1
 for <dev@dpdk.org>; Wed, 03 Feb 2016 01:26:42 -0800 (PST)
In-Reply-To: <1454078953-23744-10-git-send-email-david.marchand@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 01/29/2016 03:49 PM, David Marchand wrote:
> Reuse pci hook to implement automatic bind / unbind.
> The more I look at this, the more I think this should go to the PMDs
> themselves (with options per devices to control this), with EAL offering
> helpers to achieve this.

This sounds good to me.
As a basic software design rule, the decisions of using a given resource 
and/or performing a given operation (the intelligent knowledge) should 
systematically be taken at the maximum possible software level.
Conversely, such high-level decisions should be offered the most 
appropriate low-level services to facilitate their implementation.
In the case we are considering here - the need to bind a PCI device - 
the Poll Mode Driver of that device is the only component which actually 
knows.
Conversely, the EAL layer is the best place where to implement the
OS-dependent and/or architecture-dependent device binding services to be
invoked by PMDs at PCI device probing time.

My 2 cents,
Ivan

-- 
Ivan Boule
6WIND Development Engineer