From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37991)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aQu8T-0004xK-Il
	for qemu-devel@nongnu.org; Wed, 03 Feb 2016 04:54:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1aQu8S-00065T-Ns
	for qemu-devel@nongnu.org; Wed, 03 Feb 2016 04:54:05 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1450867706-19860-3-git-send-email-pbonzini@redhat.com>
	<20151225015522.GB26066@ad.usersys.redhat.com>
	<569368B0.7060703@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56B1CE35.4030708@redhat.com>
Date: Wed, 3 Feb 2016 10:53:57 +0100
MIME-Version: 1.0
In-Reply-To: <569368B0.7060703@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: add missing call to
 bdrv_drain_recurse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org



On 11/01/2016 09:32, Paolo Bonzini wrote:
> 
> 
> On 25/12/2015 02:55, Fam Zheng wrote:
>> On Wed, 12/23 11:48, Paolo Bonzini wrote:
>>> This is also needed in bdrv_drain_all, not just in bdrv_drain.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>>  block/io.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/block/io.c b/block/io.c
>>> index 841f5b5..bfe2544 100644
>>> --- a/block/io.c
>>> +++ b/block/io.c
>>> @@ -293,6 +293,7 @@ void bdrv_drain_all(void)
>>>          if (bs->job) {
>>>              block_job_pause(bs->job);
>>>          }
>>> +        bdrv_drain_recurse(bs);
>>>          aio_context_release(aio_context);
>>>  
>>>          if (!g_slist_find(aio_ctxs, aio_context)) {
>>> -- 
>>> 2.5.0
>>>
>>>
>>
>> Reviewed-by: Fam Zheng <famz@redhat.com>
>>
>>
> 
> Ping?

Ping^2?