From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756586AbcBCK2C (ORCPT ); Wed, 3 Feb 2016 05:28:02 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:58901 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751828AbcBCKTM (ORCPT ); Wed, 3 Feb 2016 05:19:12 -0500 X-AuditID: cbfec7f5-f79b16d000005389-60-56b1d41e24a8 Subject: Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com References: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> <1454491848-26551-5-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski Message-id: <56B1D41B.4090602@samsung.com> Date: Wed, 03 Feb 2016 19:19:07 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1454491848-26551-5-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t/xq7pyVzaGGVyZKmrRcW0xk8X1L89Z Ld68XcNk8fqFocXSfatZLO5/PcpocXnXHDaL/Z0djA4cHk82XWT02DPxJJvHnWt72Dx6m9+x eWzpv8vu0bdlFaPH501yAexRXDYpqTmZZalF+nYJXBkLz29hL5jIXnF30Q6mBsanrF2MnBwS AiYSU6ZMg7LFJC7cW8/WxcjFISSwlFFiX89jZgjnKaNE6+7DbCBVwgJREmcvfWIBSYgINDBK fL75mhkkISRQL9E48x6YzSwQKnHh5XUwm03AWGLz8iVgzbwCWhKTFu5nBLFZBFQl7ry/C1Yj KhAhcbizix2iRlDix+R7LCA2p4CrxOMrZ4F6OYBm6kncv6gFMV5eYvOat8wTGAVmIemYhVA1 C0nVAkbmVYyiqaXJBcVJ6blGesWJucWleel6yfm5mxghEfB1B+PSY1aHGAU4GJV4eCN+bQgT Yk0sK67MPcQowcGsJMKbeWZjmBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGan phakFsFkmTg4pRoYy7R4OBd/Mt9b+irtRQxnfdthtdQ3Kmmcb/krbvT92OlRPYmNzX5hgu0m /stOF+VEbB792rhjg9KUPn+jO6LTO4U/sfya/N+rK0V+Xim/XNG6BxdqprTrT+632B98ZrXU tuRrcY/v+0adv/Xy5OMdrgs23VUPfHb9iLfjKeG4ays+b5106dH+CUosxRmJhlrMRcWJACLe nv18AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.02.2016 18:30, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no need to get any data from this rtc i2c client, > it is not required to set client data for this i2c client. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > > --- > This is new in this series based on review comment from V1. > You could trim a little bit the description - "stored pointer is not retrieved anywhere, there is no call to i2c_get_clientdata()" might be sufficient but anyway: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com. [210.118.77.12]) by gmr-mx.google.com with ESMTPS id jg4si690370pac.2.2016.02.03.02.19.14 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 03 Feb 2016 02:19:14 -0800 (PST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O1Y003WNVBY4K50@mailout2.w1.samsung.com> for rtc-linux@googlegroups.com; Wed, 03 Feb 2016 10:19:10 +0000 (GMT) Subject: [rtc-linux] Re: [PATCH V2 4/5] mfd: max77686: do not set i2c client data for rtc i2c client To: Laxman Dewangan , lee.jones@linaro.org, alexandre.belloni@free-electrons.com, javier@osg.samsung.com References: <1454491848-26551-1-git-send-email-ldewangan@nvidia.com> <1454491848-26551-5-git-send-email-ldewangan@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Krzysztof Kozlowski Message-id: <56B1D41B.4090602@samsung.com> Date: Wed, 03 Feb 2016 19:19:07 +0900 MIME-version: 1.0 In-reply-to: <1454491848-26551-5-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=UTF-8 Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 03.02.2016 18:30, Laxman Dewangan wrote: > There is different RTC I2C address for RTC block in MAX77686. > Driver is creating dummy i2c client for this address to access > the register of this IP block. > > As there is no need to get any data from this rtc i2c client, > it is not required to set client data for this i2c client. > > Suggested-by: Krzysztof Kozlowski > Signed-off-by: Laxman Dewangan > CC: Krzysztof Kozlowski > CC: Javier Martinez Canillas > > --- > This is new in this series based on review comment from V1. > You could trim a little bit the description - "stored pointer is not retrieved anywhere, there is no call to i2c_get_clientdata()" might be sufficient but anyway: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.