From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgi Djakov Subject: Re: [PATCH v3] regulator: qcom-saw2: Add support for SAW2 regulators Date: Wed, 3 Feb 2016 19:28:46 +0200 Message-ID: <56B238CE.2030204@linaro.org> References: <1454322713-18729-1-git-send-email-georgi.djakov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f51.google.com ([74.125.82.51]:34115 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933372AbcBCR2w (ORCPT ); Wed, 3 Feb 2016 12:28:52 -0500 Received: by mail-wm0-f51.google.com with SMTP id 128so176255908wmz.1 for ; Wed, 03 Feb 2016 09:28:51 -0800 (PST) In-Reply-To: <1454322713-18729-1-git-send-email-georgi.djakov@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: broonie@kernel.org Cc: lgirdwood@gmail.com, andy.gross@linaro.org, lina.iyer@linaro.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org On 02/01/2016 12:31 PM, Georgi Djakov wrote: > The SAW2 (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper 2) > is part of the SPM subsystem. It is a hardware block in the Qualcomm > chipsets that regulates the power to the CPU cores on platform such as > apq8064, msm8974, apq8084 and others. > > Signed-off-by: Georgi Djakov > --- [..] > +config REGULATOR_QCOM_SAW2 > + tristate "Qualcomm SAW2 regulator driver" > + depends on ARCH_QCOM This should be: depends on (ARCH_QCOM || COMPILE_TEST) && MFD_SYSCON I plan to re-send after a few more days and also change the name of the driver from SAW2 to SAW, as we can add support for other generations than just 2. > + help > + If you say yes to this option, support will be included for the > + regulators providing power to the CPU cores on devices such as > + APQ8064. > + > + Say M here if you want to include support for the CPU core voltage > + regulators as a module. The module will be named > + "qcom_saw2-regulator". > +