From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757354AbcBDDES (ORCPT ); Wed, 3 Feb 2016 22:04:18 -0500 Received: from lists.s-osg.org ([54.187.51.154]:54310 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756909AbcBDDER (ORCPT ); Wed, 3 Feb 2016 22:04:17 -0500 Subject: Re: [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally To: Laxman Dewangan , Krzysztof Kozlowski , lee.jones@linaro.org, alexandre.belloni@free-electrons.com References: <1454507233-9959-1-git-send-email-ldewangan@nvidia.com> <1454507233-9959-6-git-send-email-ldewangan@nvidia.com> <56B296F6.3060002@samsung.com> <56B2B17A.1000509@nvidia.com> <56B2BC7B.4070807@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56B2BFA3.90409@osg.samsung.com> Date: Thu, 4 Feb 2016 00:04:03 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56B2BC7B.4070807@nvidia.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Laxman, On 02/03/2016 11:50 PM, Laxman Dewangan wrote: > Hi Javier, > > On Thursday 04 February 2016 07:33 AM, Laxman Dewangan wrote: >> >> On Thursday 04 February 2016 05:40 AM, Krzysztof Kozlowski wrote: >>> On 03.02.2016 22:47, Laxman Dewangan wrote: >>>> >>>> Changes from V2: >>>> - Taken care of missed sequence for removing the resource. >>>> - Fix the crash when doing unbind by using requested_threaded_irq() >>>> instead of demv_requested_threaded_irq(). >>>> >>>> drivers/mfd/max77686.c | 85 +------------------- >>>> drivers/rtc/rtc-max77686.c | 148 ++++++++++++++++++++++++++++++----- >>>> include/linux/mfd/max77686-private.h | 3 - >>>> 3 files changed, 130 insertions(+), 106 deletions(-) >>>> >>> Looks good and works properly (RTC, unbind/rebind, wakealarm again) >>> but... after applying this patch the device cannot suspend to RAM after >>> unbind/rebind. >>> >>> Reproduce path, after booting: >>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/unbind >>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/bind >>> $ rtcwake -d rtc2 -m mem -s 5 -v >>> (or instead of rtcwake: echo mem > /sys/power/state) >> > > Can you please also try to test in your setup which have MAX77802? > On this, we do not create i2c client and do regmap_init_i2c. So may be it helps on narrow down the issue. > Of course, I planned to test it today but ran out of time and I don't have access to my Chromebook now. I'll test it at first time tomorrow morning. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org (lists.s-osg.org. [54.187.51.154]) by gmr-mx.google.com with ESMTP id tn7si1242510pac.1.2016.02.03.19.04.11 for ; Wed, 03 Feb 2016 19:04:11 -0800 (PST) Subject: [rtc-linux] Re: [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally To: Laxman Dewangan , Krzysztof Kozlowski , lee.jones@linaro.org, alexandre.belloni@free-electrons.com References: <1454507233-9959-1-git-send-email-ldewangan@nvidia.com> <1454507233-9959-6-git-send-email-ldewangan@nvidia.com> <56B296F6.3060002@samsung.com> <56B2B17A.1000509@nvidia.com> <56B2BC7B.4070807@nvidia.com> Cc: cw00.choi@samsung.com, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com From: Javier Martinez Canillas Message-ID: <56B2BFA3.90409@osg.samsung.com> Date: Thu, 4 Feb 2016 00:04:03 -0300 MIME-Version: 1.0 In-Reply-To: <56B2BC7B.4070807@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hello Laxman, On 02/03/2016 11:50 PM, Laxman Dewangan wrote: > Hi Javier, > > On Thursday 04 February 2016 07:33 AM, Laxman Dewangan wrote: >> >> On Thursday 04 February 2016 05:40 AM, Krzysztof Kozlowski wrote: >>> On 03.02.2016 22:47, Laxman Dewangan wrote: >>>> >>>> Changes from V2: >>>> - Taken care of missed sequence for removing the resource. >>>> - Fix the crash when doing unbind by using requested_threaded_irq() >>>> instead of demv_requested_threaded_irq(). >>>> >>>> drivers/mfd/max77686.c | 85 +------------------- >>>> drivers/rtc/rtc-max77686.c | 148 ++++++++++++++++++++++++++++++----- >>>> include/linux/mfd/max77686-private.h | 3 - >>>> 3 files changed, 130 insertions(+), 106 deletions(-) >>>> >>> Looks good and works properly (RTC, unbind/rebind, wakealarm again) >>> but... after applying this patch the device cannot suspend to RAM after >>> unbind/rebind. >>> >>> Reproduce path, after booting: >>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/unbind >>> $ echo max77686-rtc > /sys/bus/platform/drivers/max77686-rtc/bind >>> $ rtcwake -d rtc2 -m mem -s 5 -v >>> (or instead of rtcwake: echo mem > /sys/power/state) >> > > Can you please also try to test in your setup which have MAX77802? > On this, we do not create i2c client and do regmap_init_i2c. So may be it helps on narrow down the issue. > Of course, I planned to test it today but ran out of time and I don't have access to my Chromebook now. I'll test it at first time tomorrow morning. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.