From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965593AbcBDOlq (ORCPT ); Thu, 4 Feb 2016 09:41:46 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:57519 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756713AbcBDOll (ORCPT ); Thu, 4 Feb 2016 09:41:41 -0500 Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support To: Timur Tabi , Fu Wei References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-6-git-send-email-fu.wei@linaro.org> <56B23883.7000501@codeaurora.org> <56B23E99.1030604@codeaurora.org> <56B2423B.1020109@codeaurora.org> <56B24642.8090105@codeaurora.org> <56B24AB5.3070001@codeaurora.org> <56B2DEE4.7060901@roeck-us.net> <56B35698.4020100@codeaurora.org> Cc: Rob Herring , =?UTF-8?Q?Pawe=c5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , Wim Van Sebroeck , Jon Corbet , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , LKML , linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Dave Young , Pratyush Anand , G Gregory , Al Stone , Hanjun Guo , Jon Masters , Arnd Bergmann , Leo Duran , Sudeep Holla From: Guenter Roeck Message-ID: <56B3631F.6090304@roeck-us.net> Date: Thu, 4 Feb 2016 06:41:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56B35698.4020100@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/04/2016 05:48 AM, Timur Tabi wrote: > Guenter Roeck wrote: >> Also, if panic is enabled, the timeout needs to be adjusted accordingly >> (to only panic after the entire timeout period has expired, not after >> half of it). We can not panic the system after timeout / 2. > > It's a debugging feature, not an actual watchdog timeout panic. That's why it's disabled by default. > "* When the first stage(the half timeout) is reached, WS0 interrupt is * triggered, at this moment the second watch period starts; * In the WS0 interrupt routine, panic will be triggered for saving the * system context. * If the system is getting into trouble and cannot be reset by panic or * restart properly by the kdump kernel(if supported), then the second * stage (the timeout) will be reached, system will be reset by WS1." That doesn't sound like debugging to me. Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support Date: Thu, 4 Feb 2016 06:41:35 -0800 Message-ID: <56B3631F.6090304@roeck-us.net> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-6-git-send-email-fu.wei@linaro.org> <56B23883.7000501@codeaurora.org> <56B23E99.1030604@codeaurora.org> <56B2423B.1020109@codeaurora.org> <56B24642.8090105@codeaurora.org> <56B24AB5.3070001@codeaurora.org> <56B2DEE4.7060901@roeck-us.net> <56B35698.4020100@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <56B35698.4020100-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Timur Tabi , Fu Wei Cc: Rob Herring , =?UTF-8?Q?Pawe=c5=82_Moll?= , Mark Rutland , Ian Campbell , Kumar Gala , Wim Van Sebroeck , Jon Corbet , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , LKML , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Linaro ACPI Mailman List , rruigrok-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, "Abdulhamid, Harb" , Christopher Covington , Dave Young , Pratyush Anand , G Gregory , Al Stone , Hanjun List-Id: devicetree@vger.kernel.org On 02/04/2016 05:48 AM, Timur Tabi wrote: > Guenter Roeck wrote: >> Also, if panic is enabled, the timeout needs to be adjusted accordingly >> (to only panic after the entire timeout period has expired, not after >> half of it). We can not panic the system after timeout / 2. > > It's a debugging feature, not an actual watchdog timeout panic. That's why it's disabled by default. > "* When the first stage(the half timeout) is reached, WS0 interrupt is * triggered, at this moment the second watch period starts; * In the WS0 interrupt routine, panic will be triggered for saving the * system context. * If the system is getting into trouble and cannot be reset by panic or * restart properly by the kdump kernel(if supported), then the second * stage (the timeout) will be reached, system will be reset by WS1." That doesn't sound like debugging to me. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@roeck-us.net (Guenter Roeck) Date: Thu, 4 Feb 2016 06:41:35 -0800 Subject: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support In-Reply-To: <56B35698.4020100@codeaurora.org> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-6-git-send-email-fu.wei@linaro.org> <56B23883.7000501@codeaurora.org> <56B23E99.1030604@codeaurora.org> <56B2423B.1020109@codeaurora.org> <56B24642.8090105@codeaurora.org> <56B24AB5.3070001@codeaurora.org> <56B2DEE4.7060901@roeck-us.net> <56B35698.4020100@codeaurora.org> Message-ID: <56B3631F.6090304@roeck-us.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/04/2016 05:48 AM, Timur Tabi wrote: > Guenter Roeck wrote: >> Also, if panic is enabled, the timeout needs to be adjusted accordingly >> (to only panic after the entire timeout period has expired, not after >> half of it). We can not panic the system after timeout / 2. > > It's a debugging feature, not an actual watchdog timeout panic. That's why it's disabled by default. > "* When the first stage(the half timeout) is reached, WS0 interrupt is * triggered, at this moment the second watch period starts; * In the WS0 interrupt routine, panic will be triggered for saving the * system context. * If the system is getting into trouble and cannot be reset by panic or * restart properly by the kdump kernel(if supported), then the second * stage (the timeout) will be reached, system will be reset by WS1." That doesn't sound like debugging to me. Guenter