From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757075AbcBDQhp (ORCPT ); Thu, 4 Feb 2016 11:37:45 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35474 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755199AbcBDQhn (ORCPT ); Thu, 4 Feb 2016 11:37:43 -0500 Subject: Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver To: Will Deacon , fu.wei@linaro.org Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, wim@iguana.be, linux@roeck-us.net, corbet@lwn.net, catalin.marinas@arm.com, Suravee.Suthikulpanit@amd.com, linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linaro-acpi@lists.linaro.org, rruigrok@codeaurora.org, harba@codeaurora.org, cov@codeaurora.org, dyoung@redhat.com, panand@redhat.com, graeme.gregory@linaro.org, al.stone@linaro.org, hanjun.guo@linaro.org, jcm@redhat.com, arnd@arndb.de, leo.duran@amd.com, sudeep.holla@arm.com References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-5-git-send-email-fu.wei@linaro.org> <20160204163101.GH17257@arm.com> From: Timur Tabi Message-ID: <56B37E52.300@codeaurora.org> Date: Thu, 4 Feb 2016 10:37:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <20160204163101.GH17257@arm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Will Deacon wrote: >> +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >> >+{ >> >+ struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >> >+ >> >+ /* >> >+ * Writing WRR for an explicit watchdog refresh. >> >+ * You can write anyting(like 0xc0ffee). >> >+ */ >> >+ writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR); >> >+ >> >+ return 0; >> >+} > You might get in trouble for that. 0xd09f00d is probably less poisonous. > > http://www.petpoisonhelpline.com/poison/caffeine/ Any reason why we can't just keep it simple and write 0? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver Date: Thu, 4 Feb 2016 10:37:38 -0600 Message-ID: <56B37E52.300@codeaurora.org> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-5-git-send-email-fu.wei@linaro.org> <20160204163101.GH17257@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160204163101.GH17257-5wv7dgnIgG8@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Will Deacon , fu.wei-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linaro-acpi-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, rruigrok-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, harba-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, panand-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, graeme.gregory-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, al.stone-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, hanjun.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, leo.duran-5C7GfCeVMHo@public.gmane.org, sudeep.holla-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org Will Deacon wrote: >> +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >> >+{ >> >+ struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >> >+ >> >+ /* >> >+ * Writing WRR for an explicit watchdog refresh. >> >+ * You can write anyting(like 0xc0ffee). >> >+ */ >> >+ writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR); >> >+ >> >+ return 0; >> >+} > You might get in trouble for that. 0xd09f00d is probably less poisonous. > > http://www.petpoisonhelpline.com/poison/caffeine/ Any reason why we can't just keep it simple and write 0? -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: timur@codeaurora.org (Timur Tabi) Date: Thu, 4 Feb 2016 10:37:38 -0600 Subject: [PATCH v10 4/5] Watchdog: introduce ARM SBSA watchdog driver In-Reply-To: <20160204163101.GH17257@arm.com> References: <1454519923-25230-1-git-send-email-fu.wei@linaro.org> <1454519923-25230-5-git-send-email-fu.wei@linaro.org> <20160204163101.GH17257@arm.com> Message-ID: <56B37E52.300@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Will Deacon wrote: >> +static int sbsa_gwdt_keepalive(struct watchdog_device *wdd) >> >+{ >> >+ struct sbsa_gwdt *gwdt = to_sbsa_gwdt(wdd); >> >+ >> >+ /* >> >+ * Writing WRR for an explicit watchdog refresh. >> >+ * You can write anyting(like 0xc0ffee). >> >+ */ >> >+ writel(0xc0ffee, gwdt->refresh_base + SBSA_GWDT_WRR); >> >+ >> >+ return 0; >> >+} > You might get in trouble for that. 0xd09f00d is probably less poisonous. > > http://www.petpoisonhelpline.com/poison/caffeine/ Any reason why we can't just keep it simple and write 0?