From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS2XR-0000JX-EU for qemu-devel@nongnu.org; Sat, 06 Feb 2016 08:04:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aS2XQ-0002fa-KU for qemu-devel@nongnu.org; Sat, 06 Feb 2016 08:04:33 -0500 References: <20160204173639.GA5772@li141-249.members.linode.com> From: Max Reitz Message-ID: <56B5EF57.2080301@redhat.com> Date: Sat, 6 Feb 2016 14:04:23 +0100 MIME-Version: 1.0 In-Reply-To: <20160204173639.GA5772@li141-249.members.linode.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wBtQnQDwn9lT1wLxc5NJSi4Oebm38e1nn" Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] blockdev: Unset temporary flag when changing medium. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alyssa Milburn , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wBtQnQDwn9lT1wLxc5NJSi4Oebm38e1nn Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 04.02.2016 18:36, Alyssa Milburn wrote: > This avoids a 'change' command from the monitor unlink()ing the new > file if the bdrv was previously snapshotted. >=20 > Signed-off-by: Alyssa Milburn > --- > blockdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/blockdev.c b/blockdev.c > index be4ca44..d39c2e6 100644 > --- a/blockdev.c > +++ b/blockdev.c > @@ -2514,6 +2514,7 @@ void qmp_blockdev_change_medium(const char *devic= e, const char *filename, > } > =20 > bdrv_flags =3D blk_get_open_flags_from_root_state(blk); > + bdrv_flags &=3D ~BDRV_O_TEMPORARY; > =20 > if (!has_read_only) { > read_only =3D BLOCKDEV_CHANGE_READ_ONLY_MODE_RETAIN; >=20 This patch is correct (thanks!), but I think we want to unset even more flags, namely BDRV_O_SNAPSHOT, BDRV_O_NO_BACKING, and BDRV_O_PROTOCOL. Max --wBtQnQDwn9lT1wLxc5NJSi4Oebm38e1nn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWte9XAAoJEDuxQgLoOKytKbUIAIkhW6aZeOUXMc0BmGwmmb7G /bO/phKwdCe5TNp3OCCmgtODGVInw0bAWkG6xK4t2OGMpyaDbb8LoY9emXB2zA5c pcdwRebD7HEzabvHcDbon99A7hZByRMHFBvPQfajjOR7WM23FjNJghBlFfB+hd2p nVU2pZlneCCGt+N2yDdG8yUFzttzJMph7+00uoC3UYAK2rXckNYsf7vtyeX/eP0C qaWWQv2yMbkxdor68dwiKi0bplpnDQoJxABBtYbGVfm8zkCKqJFaU2o3/wKglNQI YBYjny1k2OdlQcTTcjVyMJNRUzQWOTVU9rmjn0lyq1rhiof0OvKCBPbG9rr1aLc= =+Sdo -----END PGP SIGNATURE----- --wBtQnQDwn9lT1wLxc5NJSi4Oebm38e1nn--