From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755934AbcBHRvh (ORCPT ); Mon, 8 Feb 2016 12:51:37 -0500 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33156 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755821AbcBHRvf (ORCPT ); Mon, 8 Feb 2016 12:51:35 -0500 Subject: Re: [RFC 1/3] dt-bindings: soc: Add documentation for the MediaTek GCE unit To: Horng-Shyang Liao , Rob Herring References: <1453266881-16849-1-git-send-email-hs.liao@mediatek.com> <1453266881-16849-2-git-send-email-hs.liao@mediatek.com> <20160120163826.GA23400@rob-hp-laptop> <1453433893.15298.13.camel@mtksdaap41> Cc: Daniel Kurtz , Sascha Hauer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, Sascha Hauer , Philipp Zabel , Nicolas Boichat , CK HU From: Matthias Brugger Message-ID: <56B8D5A3.3000506@gmail.com> Date: Mon, 8 Feb 2016 18:51:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453433893.15298.13.camel@mtksdaap41> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/01/16 04:38, Horng-Shyang Liao wrote: > Hi Rob, > > On Wed, 2016-01-20 at 10:38 -0600, Rob Herring wrote: >> On Wed, Jan 20, 2016 at 01:14:38PM +0800, hs.liao@mediatek.com wrote: >>> From: HS Liao >>> >>> This adds documentation for the MediaTek Global Command Engine (GCE) unit >>> found in MT8173 SoCs. >>> >>> Signed-off-by: HS Liao >>> --- >>> .../devicetree/bindings/soc/mediatek/gce.txt | 33 ++++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> >>> diff --git a/Documentation/devicetree/bindings/soc/mediatek/gce.txt b/Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> new file mode 100644 >>> index 0000000..878b11e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> @@ -0,0 +1,33 @@ >>> +MediaTek GCE >>> +=============== >>> + >>> +The Global Command Engine (GCE) is used to help read/write registers with >>> +critical time limitation, such as updating display configuration during the >>> +vblank. The GCE can be used to implement the Command Queue (CMDQ) driver. >>> +Currently, the GCE only supports display related hardwares, but we expect >>> +it can be extended to other hardwares for future requirements. >> >> That's a hardware limitation or just s/w is only using it for display? >> If the latter, that's not really relevant to this binding and should be >> removed. > > Just s/w is only using it for display. > I will remove it from next patch. > >>> + >>> +Required properties: >>> +- compatible: Must be "mediatek,mt8173-gce" >>> +- reg: Address range of the GCE unit >>> +- interrupts: The interrupt signal from the GCE block >>> +- clock: Clocks according to the common clock binding >>> +- clock-names: Must be "gce" to stand for GCE clock >>> + >>> +Example: >>> + >>> + gce: gce@10212000 { >>> + compatible = "mediatek,mt8173-gce"; >>> + reg = <0 0x10212000 0 0x1000>; >>> + interrupts = ; >>> + clocks = <&infracfg CLK_INFRA_GCE>; >>> + clock-names = "gce"; >>> + }; >>> + >>> + mmsys: clock-controller@14000000 { >>> + compatible = "mediatek,mt8173-mmsys", "syscon"; >>> + reg = <0 0x14000000 0 0x1000>; >>> + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; >>> + #clock-cells = <1>; >>> + mediatek,gce = <&gce>; >> >> Not documented. > > It's just an example about how gce is used by display mmsys. > After I discussed with Mediatek display owner, > we think this can be moved to display device tree document. > Do you agree with this suggestion? > If so, I will remove it from next patch, too. > The problem is that mediatek,gce is not documented, but only mediatek,mt8173-gce. Regards, Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [RFC 1/3] dt-bindings: soc: Add documentation for the MediaTek GCE unit Date: Mon, 8 Feb 2016 18:51:31 +0100 Message-ID: <56B8D5A3.3000506@gmail.com> References: <1453266881-16849-1-git-send-email-hs.liao@mediatek.com> <1453266881-16849-2-git-send-email-hs.liao@mediatek.com> <20160120163826.GA23400@rob-hp-laptop> <1453433893.15298.13.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453433893.15298.13.camel@mtksdaap41> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Horng-Shyang Liao , Rob Herring Cc: Daniel Kurtz , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sascha Hauer , Philipp Zabel , Nicolas Boichat , CK HU List-Id: devicetree@vger.kernel.org On 22/01/16 04:38, Horng-Shyang Liao wrote: > Hi Rob, > > On Wed, 2016-01-20 at 10:38 -0600, Rob Herring wrote: >> On Wed, Jan 20, 2016 at 01:14:38PM +0800, hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: >>> From: HS Liao >>> >>> This adds documentation for the MediaTek Global Command Engine (GCE) unit >>> found in MT8173 SoCs. >>> >>> Signed-off-by: HS Liao >>> --- >>> .../devicetree/bindings/soc/mediatek/gce.txt | 33 ++++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> >>> diff --git a/Documentation/devicetree/bindings/soc/mediatek/gce.txt b/Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> new file mode 100644 >>> index 0000000..878b11e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> @@ -0,0 +1,33 @@ >>> +MediaTek GCE >>> +=============== >>> + >>> +The Global Command Engine (GCE) is used to help read/write registers with >>> +critical time limitation, such as updating display configuration during the >>> +vblank. The GCE can be used to implement the Command Queue (CMDQ) driver. >>> +Currently, the GCE only supports display related hardwares, but we expect >>> +it can be extended to other hardwares for future requirements. >> >> That's a hardware limitation or just s/w is only using it for display? >> If the latter, that's not really relevant to this binding and should be >> removed. > > Just s/w is only using it for display. > I will remove it from next patch. > >>> + >>> +Required properties: >>> +- compatible: Must be "mediatek,mt8173-gce" >>> +- reg: Address range of the GCE unit >>> +- interrupts: The interrupt signal from the GCE block >>> +- clock: Clocks according to the common clock binding >>> +- clock-names: Must be "gce" to stand for GCE clock >>> + >>> +Example: >>> + >>> + gce: gce@10212000 { >>> + compatible = "mediatek,mt8173-gce"; >>> + reg = <0 0x10212000 0 0x1000>; >>> + interrupts = ; >>> + clocks = <&infracfg CLK_INFRA_GCE>; >>> + clock-names = "gce"; >>> + }; >>> + >>> + mmsys: clock-controller@14000000 { >>> + compatible = "mediatek,mt8173-mmsys", "syscon"; >>> + reg = <0 0x14000000 0 0x1000>; >>> + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; >>> + #clock-cells = <1>; >>> + mediatek,gce = <&gce>; >> >> Not documented. > > It's just an example about how gce is used by display mmsys. > After I discussed with Mediatek display owner, > we think this can be moved to display device tree document. > Do you agree with this suggestion? > If so, I will remove it from next patch, too. > The problem is that mediatek,gce is not documented, but only mediatek,mt8173-gce. Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Mon, 8 Feb 2016 18:51:31 +0100 Subject: [RFC 1/3] dt-bindings: soc: Add documentation for the MediaTek GCE unit In-Reply-To: <1453433893.15298.13.camel@mtksdaap41> References: <1453266881-16849-1-git-send-email-hs.liao@mediatek.com> <1453266881-16849-2-git-send-email-hs.liao@mediatek.com> <20160120163826.GA23400@rob-hp-laptop> <1453433893.15298.13.camel@mtksdaap41> Message-ID: <56B8D5A3.3000506@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 22/01/16 04:38, Horng-Shyang Liao wrote: > Hi Rob, > > On Wed, 2016-01-20 at 10:38 -0600, Rob Herring wrote: >> On Wed, Jan 20, 2016 at 01:14:38PM +0800, hs.liao at mediatek.com wrote: >>> From: HS Liao >>> >>> This adds documentation for the MediaTek Global Command Engine (GCE) unit >>> found in MT8173 SoCs. >>> >>> Signed-off-by: HS Liao >>> --- >>> .../devicetree/bindings/soc/mediatek/gce.txt | 33 ++++++++++++++++++++ >>> 1 file changed, 33 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> >>> diff --git a/Documentation/devicetree/bindings/soc/mediatek/gce.txt b/Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> new file mode 100644 >>> index 0000000..878b11e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/mediatek/gce.txt >>> @@ -0,0 +1,33 @@ >>> +MediaTek GCE >>> +=============== >>> + >>> +The Global Command Engine (GCE) is used to help read/write registers with >>> +critical time limitation, such as updating display configuration during the >>> +vblank. The GCE can be used to implement the Command Queue (CMDQ) driver. >>> +Currently, the GCE only supports display related hardwares, but we expect >>> +it can be extended to other hardwares for future requirements. >> >> That's a hardware limitation or just s/w is only using it for display? >> If the latter, that's not really relevant to this binding and should be >> removed. > > Just s/w is only using it for display. > I will remove it from next patch. > >>> + >>> +Required properties: >>> +- compatible: Must be "mediatek,mt8173-gce" >>> +- reg: Address range of the GCE unit >>> +- interrupts: The interrupt signal from the GCE block >>> +- clock: Clocks according to the common clock binding >>> +- clock-names: Must be "gce" to stand for GCE clock >>> + >>> +Example: >>> + >>> + gce: gce at 10212000 { >>> + compatible = "mediatek,mt8173-gce"; >>> + reg = <0 0x10212000 0 0x1000>; >>> + interrupts = ; >>> + clocks = <&infracfg CLK_INFRA_GCE>; >>> + clock-names = "gce"; >>> + }; >>> + >>> + mmsys: clock-controller at 14000000 { >>> + compatible = "mediatek,mt8173-mmsys", "syscon"; >>> + reg = <0 0x14000000 0 0x1000>; >>> + power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; >>> + #clock-cells = <1>; >>> + mediatek,gce = <&gce>; >> >> Not documented. > > It's just an example about how gce is used by display mmsys. > After I discussed with Mediatek display owner, > we think this can be moved to display device tree document. > Do you agree with this suggestion? > If so, I will remove it from next patch, too. > The problem is that mediatek,gce is not documented, but only mediatek,mt8173-gce. Regards, Matthias