From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755253AbcBIIDj (ORCPT ); Tue, 9 Feb 2016 03:03:39 -0500 Received: from mail.bmw-carit.de ([62.245.222.98]:51682 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751899AbcBIIDh (ORCPT ); Tue, 9 Feb 2016 03:03:37 -0500 X-CTCH-RefID: str=0001.0A0C0205.56B99D56.00E6,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Subject: Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header To: "Maciej W. Rozycki" References: <201602090033.mukhdG4N%fengguang.wu@intel.com> CC: kbuild test robot , , Ralf Baechle , , From: Daniel Wagner X-Enigmail-Draft-Status: N1110 Message-ID: <56B99D55.2020301@bmw-carit.de> Date: Tue, 9 Feb 2016 09:03:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <201602090033.mukhdG4N%fengguang.wu@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maciej, On 02/08/2016 05:22 PM, kbuild test robot wrote: > Hi Daniel, > > [auto build test ERROR on v4.5-rc3] > [also build test ERROR on next-20160208] > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] > > url: https://github.com/0day-ci/linux/commits/Daniel-Wagner/Differentiate-between-32-and-64-bit-ELF-header/20160208-234759 > config: mips-fuloong2e_defconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=mips > > All error/warnings (new ones prefixed by >>): > > arch/mips/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_interp': >>> arch/mips/kernel/binfmt_elfn32.c:38:7: error: implicit declaration of function 'mips_elf_check_machine' [-Werror=implicit-function-declaration] > if (!mips_elf_check_machine(__h)) \ > ^ >>> arch/mips/kernel/../../../fs/binfmt_elf.c:536:7: note: in expansion of macro 'elf_check_arch' > if (!elf_check_arch(interp_elf_ex)) > ^ > cc1: some warnings being treated as errors > -- > arch/mips/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_interp': Hmm how I was able to build binfmt_elfo32.o because it should suffer from the same problem. I think reusing mips_elf_check_machine() in binfmt_elf?32.c is only going to work if we include arch/mips/include/asm/elf.h. Though this looks kind of wrong. Should I add a mips_elf_check_machine() to binfmt_elf?32.c as well or just leave them as they are at this point? cheers, daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.bmw-carit.de ([62.245.222.98]:46996 "EHLO mail.bmw-carit.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010545AbcBIIDgva275 (ORCPT ); Tue, 9 Feb 2016 09:03:36 +0100 Subject: Re: [PATCH v3 3/3] mips: Differentiate between 32 and 64 bit ELF header References: <201602090033.mukhdG4N%fengguang.wu@intel.com> From: Daniel Wagner Message-ID: <56B99D55.2020301@bmw-carit.de> Date: Tue, 9 Feb 2016 09:03:33 +0100 MIME-Version: 1.0 In-Reply-To: <201602090033.mukhdG4N%fengguang.wu@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: "Maciej W. Rozycki" Cc: kbuild test robot , kbuild-all@01.org, Ralf Baechle , linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Message-ID: <20160209080333.iNT7t9NvxJQfhGNiJFzIffkhiqm9KC4sep8J83JJ13c@z> Hi Maciej, On 02/08/2016 05:22 PM, kbuild test robot wrote: > Hi Daniel, > > [auto build test ERROR on v4.5-rc3] > [also build test ERROR on next-20160208] > [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] > > url: https://github.com/0day-ci/linux/commits/Daniel-Wagner/Differentiate-between-32-and-64-bit-ELF-header/20160208-234759 > config: mips-fuloong2e_defconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=mips > > All error/warnings (new ones prefixed by >>): > > arch/mips/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_interp': >>> arch/mips/kernel/binfmt_elfn32.c:38:7: error: implicit declaration of function 'mips_elf_check_machine' [-Werror=implicit-function-declaration] > if (!mips_elf_check_machine(__h)) \ > ^ >>> arch/mips/kernel/../../../fs/binfmt_elf.c:536:7: note: in expansion of macro 'elf_check_arch' > if (!elf_check_arch(interp_elf_ex)) > ^ > cc1: some warnings being treated as errors > -- > arch/mips/kernel/../../../fs/binfmt_elf.c: In function 'load_elf_interp': Hmm how I was able to build binfmt_elfo32.o because it should suffer from the same problem. I think reusing mips_elf_check_machine() in binfmt_elf?32.c is only going to work if we include arch/mips/include/asm/elf.h. Though this looks kind of wrong. Should I add a mips_elf_check_machine() to binfmt_elf?32.c as well or just leave them as they are at this point? cheers, daniel