From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60651) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aT9QM-0000Aq-I2 for qemu-devel@nongnu.org; Tue, 09 Feb 2016 09:37:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aT9QJ-0007Q0-Av for qemu-devel@nongnu.org; Tue, 09 Feb 2016 09:37:50 -0500 Sender: Paolo Bonzini References: <1455027417-32278-1-git-send-email-pbonzini@redhat.com> <20160209142120.GM24614@redhat.com> From: Paolo Bonzini Message-ID: <56B9F9B8.4000403@redhat.com> Date: Tue, 9 Feb 2016 15:37:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] w32: include winsock2.h before windows.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , "Daniel P. Berrange" Cc: QEMU Trivial , QEMU Developers On 09/02/2016 15:28, Peter Maydell wrote: > On 9 February 2016 at 14:21, Daniel P. Berrange wrote: >> > On Tue, Feb 09, 2016 at 03:16:57PM +0100, Paolo Bonzini wrote: >> > include/qemu/sockets.h also has windows.h included before winsock2.h >> > >> > Presumably it didn't cause a failure for you because everything using >> > sockets.h already pulls in osdep.h. A reason to prune sockets.h >> > headers perhaps. > More generally we could prune anything including windows.h manually > (there are a dozen or so .c and .h files doing that currently). I honestly do not have time to work on this. :( Paolo