From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932423AbcBIPHw (ORCPT ); Tue, 9 Feb 2016 10:07:52 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34115 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753082AbcBIPHu (ORCPT ); Tue, 9 Feb 2016 10:07:50 -0500 Subject: Re: [PATCH 2/3] KVM: x86: consolidate "has lapic" checks into irq.c To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1454948146-35353-1-git-send-email-pbonzini@redhat.com> <1454948146-35353-3-git-send-email-pbonzini@redhat.com> <20160209140543.GB30378@potion.brq.redhat.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org From: Paolo Bonzini Message-ID: <56BA00C4.4040108@redhat.com> Date: Tue, 9 Feb 2016 16:07:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160209140543.GB30378@potion.brq.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2016 15:05, Radim Krčmář wrote: > 2016-02-08 17:15+0100, Paolo Bonzini: >> Do for kvm_cpu_has_pending_timer and kvm_inject_pending_timer_irqs >> what the other irq.c routines have been doing. >> >> Signed-off-by: Paolo Bonzini >> --- >> diff --git a/arch/x86/kvm/irq.c b/arch/x86/kvm/irq.c >> @@ -33,7 +33,10 @@ >> */ >> int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu) >> { >> - return apic_has_pending_timer(vcpu); >> + if (lapic_in_kernel(vcpu)) >> + return apic_has_pending_timer(vcpu); >> + >> + return true; > > Apart from int/bool mismatch, it returned 0 before and that was correct. > So that means "return 0;" implies "Reviewed-by"? :) Paolo