From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTAsf-0004Fb-3r for qemu-devel@nongnu.org; Tue, 09 Feb 2016 11:11:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTAsb-00052O-HE for qemu-devel@nongnu.org; Tue, 09 Feb 2016 11:11:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTAsb-00052I-A3 for qemu-devel@nongnu.org; Tue, 09 Feb 2016 11:11:05 -0500 References: <1455031511-23684-1-git-send-email-peter.maydell@linaro.org> <56BA0F09.8060302@redhat.com> From: Eric Blake Message-ID: <56BA0F98.2040300@redhat.com> Date: Tue, 9 Feb 2016 09:11:04 -0700 MIME-Version: 1.0 In-Reply-To: <56BA0F09.8060302@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3mb8buiUtKxHXqkpn4nL3BlGHE9HcGlDh" Subject: Re: [Qemu-devel] [PATCH 00/14] More #include cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: patches@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3mb8buiUtKxHXqkpn4nL3BlGHE9HcGlDh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/09/2016 09:08 AM, Eric Blake wrote: > On 02/09/2016 08:24 AM, Peter Maydell wrote: >> This set of patches does a bunch more cleaning of includes. >> Specifically it does everything necessary to be able to >> remove osdep.h includes from header files including qemu-common.h >> >> Most of these patches are small, except for the one which >> deals with tests/ (that one has already been reviewed). >> There are several patches which fix code generators to >> generate correct #includes, and some which do manual changes >> to C++ or other files that Coccinelle barfs on. >> >> The "all:" patch is running clean-includes on the whole >> tree to pick up some new files which have been added >> recently (mostly via target-arm). >> >> I've thrown in a couple of patches that have already appeared >> on list, just to get the whole set into one series. >> >> I have some pending patches which: >> * enhance clean-includes to handle header files >> * clean up header files >> * add a --all option to clean-includes to do a "run clean >> on whole tree" >> >> but I'd like to get the "add missing includes to .c files" >> parts into master before moving onto "remove includes from .h >> files" part... >=20 > Reviewed-by: Eric Blake But failed testing: CC disas/arm.o CXX disas/arm-a64.o In file included from /usr/include/c++/5.3.1/cmath:41:0, from /home/eblake/qemu-tmp/disas/libvixl/vixl/utils.h:31= , from /home/eblake/qemu-tmp/disas/libvixl/vixl/a64/disasm-a64.h:31, from disas/arm-a64.cc:25: /usr/include/c++/5.3.1/x86_64-redhat-linux/bits/c++config.h:1991:10: error: expected unqualified-id before =E2=80=98namespace=E2=80=99 inline namespace __cxx11 __attribute__((__abi_tag__ ("cxx11"))) { } ^ Not sure what went wrong there, but 3/14 probably needs tweaking. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --3mb8buiUtKxHXqkpn4nL3BlGHE9HcGlDh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWug+YAAoJEKeha0olJ0NqFN4H/iYKgc38PYqNpnaTeBXe5M4f 5ef32CPec/UfOZYUzR3iXn3Nk4UPcV1jtBG1yBx1Op74Cq1HFbnnu6reubr/O9+h NfG69BKTEYOfZBlA03hal0iKdkf8kzOdPHuKn5v+86k8Yfby4JM4pP9LBIhwytEV hbZH8Vr1TESL+sfZX4QKUbIbiscuu0DVFqQq3HSrFWz7tGXE1qhpxfZtfB8UO2pP zcekWT23nQxWNx6jyJjsFUwzIdxgAPhdhv7bYhMfBdbjtXOYDmlBC73wWJ4xIR5v rX3yh1CpQdhu6cjmv/78cdnEI25eQ/6Hi7Jzdd0RIrcTMy0SU5e88EN6/YyJS78= =TQSp -----END PGP SIGNATURE----- --3mb8buiUtKxHXqkpn4nL3BlGHE9HcGlDh--