From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964873AbcBIQRl (ORCPT ); Tue, 9 Feb 2016 11:17:41 -0500 Received: from foss.arm.com ([217.140.101.70]:41458 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932397AbcBIQRg (ORCPT ); Tue, 9 Feb 2016 11:17:36 -0500 Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base To: Mark Rutland , Stuart Yoder References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> <56B9D62E.8080003@arm.com> <20160209160812.GC9332@leverpostej> Cc: Marc Zyngier , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "david.daney@cavium.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" From: Robin Murphy Message-ID: <56BA111D.9050807@arm.com> Date: Tue, 9 Feb 2016 16:17:33 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160209160812.GC9332@leverpostej> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/16 16:08, Mark Rutland wrote: [...] >>>> having msi-map-mask clash with a nonzero rid-base, as that's another >>>> thing one can easily get wrong. [...] >>>> + if (rid_base & ~map_mask) { >>>> + dev_err(parent_dev, >>>> + "Invalid msi-map translation - msi-map-mask (0x%x) ignores rid- >>> base (0x%x)\n", >>>> + map_mask, rid_base); >>>> + return rid_out; >>>> + } [...] >> msi-map = <0x0100 &its 0x11 0x1>; >> msi-map-mask = <0xff>; >> > > I'd say that this is an inconsistent set of properties, and it's > probably worth warning if we encounter this. There is no possible way > that rid-base can be encountered. Indeed ;) Robin. > Thanks, > Mark. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base Date: Tue, 9 Feb 2016 16:17:33 +0000 Message-ID: <56BA111D.9050807@arm.com> References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> <56B9D62E.8080003@arm.com> <20160209160812.GC9332@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160209160812.GC9332@leverpostej> Sender: linux-kernel-owner@vger.kernel.org To: Mark Rutland , Stuart Yoder Cc: Marc Zyngier , "robh+dt@kernel.org" , "frowand.list@gmail.com" , "grant.likely@linaro.org" , "devicetree@vger.kernel.org" , "david.daney@cavium.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 09/02/16 16:08, Mark Rutland wrote: [...] >>>> having msi-map-mask clash with a nonzero rid-base, as that's another >>>> thing one can easily get wrong. [...] >>>> + if (rid_base & ~map_mask) { >>>> + dev_err(parent_dev, >>>> + "Invalid msi-map translation - msi-map-mask (0x%x) ignores rid- >>> base (0x%x)\n", >>>> + map_mask, rid_base); >>>> + return rid_out; >>>> + } [...] >> msi-map = <0x0100 &its 0x11 0x1>; >> msi-map-mask = <0xff>; >> > > I'd say that this is an inconsistent set of properties, and it's > probably worth warning if we encounter this. There is no possible way > that rid-base can be encountered. Indeed ;) Robin. > Thanks, > Mark. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: robin.murphy@arm.com (Robin Murphy) Date: Tue, 9 Feb 2016 16:17:33 +0000 Subject: [PATCH] of/irq: Fix msi-map calculation for nonzero rid-base In-Reply-To: <20160209160812.GC9332@leverpostej> References: <9f6845195d03b0e0b0d187bb510fbf7bd497e836.1455015344.git.robin.murphy@arm.com> <56B9D62E.8080003@arm.com> <20160209160812.GC9332@leverpostej> Message-ID: <56BA111D.9050807@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/02/16 16:08, Mark Rutland wrote: [...] >>>> having msi-map-mask clash with a nonzero rid-base, as that's another >>>> thing one can easily get wrong. [...] >>>> + if (rid_base & ~map_mask) { >>>> + dev_err(parent_dev, >>>> + "Invalid msi-map translation - msi-map-mask (0x%x) ignores rid- >>> base (0x%x)\n", >>>> + map_mask, rid_base); >>>> + return rid_out; >>>> + } [...] >> msi-map = <0x0100 &its 0x11 0x1>; >> msi-map-mask = <0xff>; >> > > I'd say that this is an inconsistent set of properties, and it's > probably worth warning if we encounter this. There is no possible way > that rid-base can be encountered. Indeed ;) Robin. > Thanks, > Mark. >